Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniz-sys: add support for using system-wide miniz #143

Closed
ignatenkobrain opened this issue Jan 10, 2018 · 3 comments
Closed

miniz-sys: add support for using system-wide miniz #143

ignatenkobrain opened this issue Jan 10, 2018 · 3 comments

Comments

@ignatenkobrain
Copy link
Contributor

In Fedora we unbundle all libraries and would like to not use bundled miniz.

There is no pkg-config, but simple #include <miniz.h> and -lminiz should work just fine.

@infinity0
Copy link

Alternatively, reimplement miniz in rust?

I see rustc already dropped miniz and there are a couple of alternatives:

https://github.com/alexchandel/miniz-rs
https://github.com/Frommi/miniz_oxide

The latter one even recreates the API of C-miniz.

@infinity0
Copy link

In Debian we just patch away miniz and miniz_oxide_c_api to use zlib instead.

I suggested #181 as an alternative; I don't see the value of including either miniz or miniz_oxide_c_api in Debian or anywhere else really, when pretty much all systems already have a zlib, especially in light of issues like #142.

@joshtriplett
Copy link
Member

flate2 now defaults to miniz_oxide rather than miniz-sys, and if you can count on system libraries then you're more likely to have zlib than miniz. I don't think there's much value in supporting a system miniz; even the miniz-sys feature is more-or-less deprecated and only exists for compatibility.

I think this can probably be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants