Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024: Add chapter on single-line where clauses #340

Conversation

joshtriplett
Copy link
Member

@joshtriplett joshtriplett commented Dec 4, 2024

@joshtriplett joshtriplett force-pushed the edition-guide-rustfmt-single-line-where-clauses branch from 15f289d to 7ef8e6a Compare December 4, 2024 21:13
@traviscross traviscross force-pushed the edition-guide-rustfmt-single-line-where-clauses branch from 7ef8e6a to c7f855b Compare December 4, 2024 21:17
@traviscross traviscross force-pushed the edition-guide-rustfmt-single-line-where-clauses branch from c7f855b to a47ea59 Compare December 4, 2024 21:20
@traviscross traviscross force-pushed the edition-guide-rustfmt-single-line-where-clauses branch from a47ea59 to 027da04 Compare December 4, 2024 21:23
@traviscross traviscross enabled auto-merge December 4, 2024 21:24
@traviscross traviscross added this pull request to the merge queue Dec 4, 2024
Merged via the queue into rust-lang:master with commit 7a957fa Dec 4, 2024
2 checks passed
@ehuss
Copy link
Contributor

ehuss commented Dec 4, 2024

This formatting doesn't seem to actually work for me. I have rustfmt 1.8.0-nightly (c44b3d50fe 2024-12-03).

Can you say more about how to get this formatting to work?

@traviscross
Copy link
Contributor

traviscross commented Dec 5, 2024

This one is still marked impl-incomplete on the tracking issue. Maybe it doesn't.

cc @calebcartwright @ytmimi

@ytmimi
Copy link

ytmimi commented Dec 5, 2024

To the best of my knowledge this has't been implemented yet, and I don't think there's an open PR for this on the rustfmt side. @calebcartwright, please correct me if I'm wrong. Also, are these rules limited to type aliases / associated types or are they meant to apply to all where clauses?

@traviscross
Copy link
Contributor

Associated types and associated function or method declarations with no default body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants