Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show pending CDN invalidations on queue page #1897

Merged
merged 2 commits into from
Nov 14, 2022
Merged

show pending CDN invalidations on queue page #1897

merged 2 commits into from
Nov 14, 2022

Conversation

syphar
Copy link
Member

@syphar syphar commented Nov 8, 2022

Since #1880 raised some more open questions, here a simple addition to the queue page. I'll finish up #1880 separately, same for actually querying the cloudfront API to get the invalidations.

This is IMO the last piece missing to really enable #1552 in the CDN configuration.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 8, 2022
@syphar
Copy link
Member Author

syphar commented Nov 9, 2022

r? @jsha @jyn514 ?

@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2022

Error: The feature assign is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@syphar
Copy link
Member Author

syphar commented Nov 10, 2022

This is how it looks like right now:
grafik

@syphar
Copy link
Member Author

syphar commented Nov 13, 2022

ping @rust-lang/docs-rs

I would love a review / feeback here.

This is the last piece missing before we can activate the full page caching for docs.

jsha
jsha approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, both UI and code. I have not tested locally. Thanks for working on this!

src/cdn.rs Outdated Show resolved Hide resolved
@syphar syphar merged commit 33d17e4 into rust-lang:master Nov 14, 2022
@syphar syphar deleted the cdn-status-3 branch November 14, 2022 08:28
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 14, 2022
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha jsha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syphar @rustbot @jsha