Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering uploaded files #588

Open
Zexbe opened this issue Feb 3, 2020 · 3 comments · May be fixed by #794
Open

Filtering uploaded files #588

Zexbe opened this issue Feb 3, 2020 · 3 comments · May be fixed by #794

Comments

@Zexbe
Copy link
Contributor

Zexbe commented Feb 3, 2020

When dealing with crates, the site should check that they are a sane size, and file type before uploading them. Ex: 100gb video should be blocked.
@jyn514
Copy link
Member

jyn514 commented Feb 3, 2020

Relevant code: https://github.com/rust-lang/docs.rs/blob/master/src/db/file.rs#L190

@Kixiron
Copy link
Member

Kixiron commented May 30, 2020

What seems like a reasonable file size limit @jyn514?

@Kixiron Kixiron linked a pull request May 30, 2020 that will close this issue
Open
@syphar
Copy link
Member

syphar commented Aug 2, 2023

From what I understand, a 100 GB video file could only end up in docs.rs, if it was previously uploaded to crates.io too, which I assume has reasonable limits.

I could imagine that macro generated docs could reach sizes that are bigger (megabytes?), so some limit is perhaps helpful to releave the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add crate file size upload limits Kixiron/docs.rs
4 participants
@syphar @Zexbe @jyn514 @Kixiron