Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build errors in my crates (possibly due to 2018 edition?) #231

Closed
Kimundi opened this issue Sep 1, 2018 · 8 comments
Closed

Build errors in my crates (possibly due to 2018 edition?) #231

Kimundi opened this issue Sep 1, 2018 · 8 comments

Comments

@Kimundi
Copy link
Member

Kimundi commented Sep 1, 2018

I'm getting build errors for a collection of crates a recently published. The errors seem to imply that doc.rs does not pick up the cargo feature for the 2018 Rust edition yet.

Is this an not-yet-implemented bug of doc.rs, or is this considered functionality that will not be supported until its stable?

@Kimundi Kimundi changed the title Build errors (possibly due to 2018 edition?) Build errors in my crates (possibly due to 2018 edition?) Sep 1, 2018
@Kimundi
Copy link
Member Author

Kimundi commented Sep 3, 2018

Update: The issue still exists, but I've worked around it for now by going back to the 2015 edition.

@fMeow
Copy link

fMeow commented Sep 13, 2018

Yes, the rustdoc compiler version is 1.28. I think it is in stable channel, which miss rust 2018 support for the time being. Any idea how to force nightly rustc in docs.rs like 1.30?

@eopb
Copy link

eopb commented Sep 14, 2018

It would be good to see this working. 2018 is awesome and I want to use it with rustdoc

@dekellum
Copy link

Looks like its using a nightly, but its pinned to nightly-2018-06-03, prior to any edition support:

https://github.com/onur/docs.rs/blob/09d4ed5d49e6e7243320fa3888bdc6c6acde28b4/Vagrantfile#L50

@dekellum
Copy link

Actually, its stranger than that. Recent docs.rs failures include a log showing the following versions.

https://docs.rs/crate/futures-preview/0.3.0-alpha.8/builds/121935

$ rustc --version
rustc 1.28.0-dev (b9bf4f162 2018-06-02)
$ cratesfyi --version
cratesfyi 0.5.0 (579f83b 2018-03-05)

Where the rustc sha matches the merge: onur/rust@b9bf4f162.
Which has rust-lang/rust@edae1cc3 as the rust-side parent being merged.

So rustc 1.28.0-nightly (4ecf12bf0 2018-06-02) is a close approximation which can still be installed with rustup (e.g. rustup install nightly-2018-06-03) to test cargo doc` behavior. Note this is 2 months before a stable channel 1.28 was released before the edition feature of cargo became stable.

@QuietMisdreavus
Copy link
Member

Since #243 has been merged, docs.rs is using a version of Cargo that can use the edition feature and config item. I've also manually rebuilt greenwasm's docs for version 0.3.1: https://docs.rs/greenwasm/0.3.1/greenwasm/

@Kimundi
Copy link
Member Author

Kimundi commented Dec 13, 2018

Seems like this can be closed then, right?

@QuietMisdreavus
Copy link
Member

Looks like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants