Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking question mark for help menu blurs whole page #1076

Closed
jsha opened this issue Oct 7, 2020 · 3 comments
Closed

Clicking question mark for help menu blurs whole page #1076

jsha opened this issue Oct 7, 2020 · 3 comments
Labels
A-frontend Area: Web frontend A-rustdoc-css Area: CSS generated by rustdoc for documentation pages C-bug Category: This is a bug

Comments

@jsha
Copy link
Contributor

jsha commented Oct 7, 2020

Steps to reproduce:

  1. Visit a docs page, like https://docs.rs/ureq/1.5.1/ureq/
  2. Click the '?' icon next to the search box, OR press ? on the keyboard.

(On Chrome 85.0.4183.121 (Official Build) (64-bit), Linux)

Expected result:

Help menu pops up.

Actual result:

Help menu pops up, but it is blurred along with the whole page.

image
@jyn514 jyn514 added A-frontend Area: Web frontend C-bug Category: This is a bug labels Oct 7, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 7, 2020

Rustdoc must have recently changed its styles. It's applying blur to body, not just to the <section id=main>. @GuillaumeGomez can you warn docs.rs before making changes like this?

There are two possible solutions:

body.blur > :not(#help) {
    filter: blur(8px);
    -webkit-filter: blur(8px);
    opacity: .7;
}

@jyn514 jyn514 added the A-rustdoc-css Area: CSS generated by rustdoc for documentation pages label Oct 7, 2020
@GuillaumeGomez
Copy link
Member

It's been like this for ages, no?

@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 7, 2020
Closed
@benediktwerner
Copy link
Contributor

This was fixed by #1080

@jyn514 jyn514 closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Web frontend A-rustdoc-css Area: CSS generated by rustdoc for documentation pages C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jsha @GuillaumeGomez @benediktwerner @jyn514