Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dry-run publish API #1515

Closed
joelgallant opened this issue Oct 12, 2018 · 2 comments
Closed

Add a dry-run publish API #1515

joelgallant opened this issue Oct 12, 2018 · 2 comments
Labels
A-publish C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works

Comments

@joelgallant
Copy link

In rust-lang/cargo#6150, @sfackler suggested that crates.io could have a dry-run publishing API endpoint, so it can enforce any requirements (like wildcard deps) in cargo publish --dry-run.

I'd love to help out with that, if it's something worth doing.

@nkconnor
Copy link

Reserved names would also be useful to catch with this; e.g. I got hit with

error: api errors (status 200 OK): cannot upload a crate with a reserved name

trying to publish my first crate, and had to dig pretty hard to find that it was part of the DB migration here

@jtgeibel
Copy link
Member

If anyone has time to dig into this, now might be a good time to revisit this. We've been tracking some refactoring in #1522 and this may be easier to implement now. The goal is to make sure the desired checks are done early in the pipeline, before writing anything to the database. All database writes should occur after we return from the --dry-run publish and the only external service I think we should possibly hit is to check team membership if necessary.

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works and removed C-feature-request labels Feb 11, 2021
@rust-lang rust-lang locked and limited conversation to collaborators Dec 23, 2021
@Turbo87 Turbo87 converted this issue into discussion #4329 Dec 23, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
A-publish C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

No branches or pull requests

5 participants