Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers in final reports are confusing #702

Open
RalfJung opened this issue Oct 2, 2023 · 0 comments
Open

Numbers in final reports are confusing #702

RalfJung opened this issue Oct 2, 2023 · 0 comments

Comments

@RalfJung
Copy link
Member

RalfJung commented Oct 2, 2023

I am looking at the regressions reported in https://crater-reports.s3.amazonaws.com/pr-116284/index.html, and I am quite confused trying to interpret this.

  • There is "regressed: root results (1 different results, 11 regressed crates in total)", but when I open it it only shows 4 crates, not 11. What's up with the missing 7 crates?
  • There is "regressed: dependencies (33 root crates, 11 regressed crates in total)", which first says it is about dependencies but then also somehow is about 33 root crates?
  • So depending on where I look, there are either 4, 11, or 33 root crates that regressed. Which number is the correct one?
  • Which of these groups should I go through to analyze the impact of the PR this experiment was about? I would expect I should only go through "root results", but the page displays "dependencies" first, indicating they are more important than root results, and it displays them both is the same style (very red), so should I go through bot of them then?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant