Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --emit=thin-link-bitcode to enable distributed ThinLTO users #735

Closed
1 of 3 tasks
durin42 opened this issue Apr 2, 2024 · 5 comments
Closed
1 of 3 tasks

Add --emit=thin-link-bitcode to enable distributed ThinLTO users #735

durin42 opened this issue Apr 2, 2024 · 5 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@durin42
Copy link

durin42 commented Apr 2, 2024

Proposal

Clang supports distributed ThinLTO which is used by bazel and buck2 for C++ to support ThinLTO for extremely large programs. In order to make Rust a full participant of such ecosystems, we need to support emitting the "ThinLTO Index" file during codegen so that the pre-link
indexing step can operate on Rust-originated object files identically to C/C++ ones.

I expect we'd want to come back and try to stabilize this only after doing work to make use of non-rustc linkers supported, which is on our backlog to discuss but not something we can do today.

I have a working proof of concept of this MCP as a patch on my fork of rust-lang/rust. The new format is guarded by requiring users to specify -Zunstable-options.

Mentors or Reviewers

If you have a reviewer or mentor in mind for this work, mention them here. You can put your own name here if you are planning to mentor the work.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area
    can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are
      proposing a new public-facing feature, such as a -C flag, then full
      team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge
      on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no
    objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@durin42 durin42 added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Apr 2, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2024

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rustbot concern reason-for-concern 
<description of the concern> 

Concerns can be lifted with:

@rustbot resolve reason-for-concern 

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Apr 2, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 4, 2024
@durin42 durin42 changed the title Add -Zemit-thin-lto-index=<path> to enable distributed ThinLTO users Add --emit=thin-link-bitcode to enable distributed ThinLTO users Apr 30, 2024
@tmandry
Copy link
Member

tmandry commented May 3, 2024

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label May 3, 2024
@nnethercote
Copy link

Why is the Zulip stream empty?

@bjorn3
Copy link
Member

bjorn3 commented May 22, 2024

https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/Add.20.60--emit.3Dthin-link-bitcode.60.20to.20enable.20.E2.80.A6.20compiler-team.23735 is the correct stream. This MCP was renamed, but triagebot doesn't change the link in it's comment.

@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels May 25, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

6 participants