Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support debug fission using -Csplit-debuginfo=post-link #721

Closed
1 of 3 tasks
bjorn3 opened this issue Feb 6, 2024 · 3 comments
Closed
1 of 3 tasks

Support debug fission using -Csplit-debuginfo=post-link #721

bjorn3 opened this issue Feb 6, 2024 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@bjorn3
Copy link
Member

bjorn3 commented Feb 6, 2024

Proposal

On macOS and Windows -Csplit-debuginfo=packed puts all debuginfo in a separate file. This avoids leaking sensitive information into release executables while still allowing debugging with those debuginfo files and reduces file size. On Linux however we make use of dwarf split debuginfo, which puts a fair amount of information into the executable itself, leaking sensitive data like build paths, and increases the size of executables. Instead I propose to add an option to use debug fission where the debuginfo sections are copied out of the executable into a separate file and buildid is used to be able to locate the right debuginfo file. This is what all major linux distros use for debuginfo. This disadvantage over the current scheme is longer linking time, but for local development -Csplit-debuginfo=unpacked is a better choice anyway, which I propose to keep using dwarf split debuginfo as is. This way -Csplit-debuginfo=unpacked is the best choice for local development and the new -Csplit-debuginfo=post-link is the best choice for release builds across all platforms that support the respective options. -Csplit-debuginfo=post-link would be equivalent to -Csplit-debuginfo=packed on Windows and macOS.

Mentors or Reviewers

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@bjorn3 bjorn3 added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Feb 6, 2024
@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2024

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rustbot concern reason-for-concern 
<description of the concern> 

Concerns can be lifted with:

@rustbot resolve reason-for-concern 

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Feb 6, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Feb 8, 2024
@bjorn3 bjorn3 changed the title Use debug fission instead of dwarf split debuginfo for -Csplit-debuginfo=packed Support debug fission using -Csplit-debuginfo=post-link Feb 21, 2024
@michaelwoerister
Copy link
Member

@rustbot second

Thanks, @bjorn3!

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Feb 21, 2024
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants