Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc is using rustc_ast_pretty, would it be possible to make it somewhat "stable"? #403

Closed
GuillaumeGomez opened this issue Jan 28, 2021 · 2 comments
Closed

rustdoc is using rustc_ast_pretty, would it be possible to make it somewhat "stable"? #403

GuillaumeGomez opened this issue Jan 28, 2021 · 2 comments
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jan 28, 2021 •
edited
Loading

Proposal

Like said in the title, rustdoc is using rustc_ast_pretty to render some elements. @oli-obk suggested me to open a MCP so that:

  1. The compiler team is aware of this fact.
  2. Maybe somewhat "stabilize" it so that no unexpected and potentially breaking changes come up

Linked to rust-lang/rust#81438.
@GuillaumeGomez GuillaumeGomez added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Jan 28, 2021
@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2021

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jan 28, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Feb 4, 2021
@jyn514 jyn514 mentioned this issue Jun 26, 2021
Merged
@wesleywiser
Copy link
Member

wesleywiser commented Oct 22, 2021 •
edited
Loading

We've discussed this in a number of compiler team meetings and we would like to see the proposal fleshed out more completely. I'm going to close this now due to inactivity but please re-open (or submit a new MCP) when you've had a chance to revisit this!

discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wesleywiser @GuillaumeGomez @apiraino @rustbot