Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFI directives missing on __rust_probestack #325

Closed
tmandry opened this issue Nov 14, 2019 · 3 comments
Closed

CFI directives missing on __rust_probestack #325

tmandry opened this issue Nov 14, 2019 · 3 comments

Comments

@tmandry
Copy link
Member

tmandry commented Nov 14, 2019

#306 added frame pointers so that backtraces would be available from failed stack probes. Unfortunately, this does not work in build configurations which use DWARF/CFI information for unwinding. (On Fuchsia we use this exclusively, but it's an option on other platforms as well.)

The way of enabling backtraces on these platforms is to use CFI directives, like #305 did. Unfortunately, that implementation was messier due to needing external assembly files. Still, it's the only way to get full backtrace information in DWARF.

@alexcrichton
Copy link
Member

I'm not familiar with it myself, but if LLVM inline assembly has a way to support this that'd be the best way to go. If not, though, using assembly files for rust-lang/rust builds and having the inline-Rust used for other builds seems like a possible way to go to fix this

@tmandry
Copy link
Member Author

tmandry commented Nov 15, 2019

It does seem possible to use LLVM inline assembly; see example.

@tmandry
Copy link
Member Author

tmandry commented Dec 7, 2019

Fixed by #328.

@tmandry tmandry closed this as completed Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants