Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/upgrade Chalk in wake of librarifying Copy/Clone on arrays and reinstate test #758

Open
bstrie opened this issue Jun 12, 2021 · 1 comment
Labels
C-chalk-solve Issues related to the chalk-solve crate

Comments

@bstrie
Copy link

bstrie commented Jun 12, 2021

Prior to rust-lang/rust#86041 , Copy and Clone are implemented on arrays by way of compiler magic. Now that const generics exist, these magical impls can be converted to proper library impls. Changes to trait selection were necessary to make this happen. However, rustc's test suite also contains some tests for rustc's next-gen trait selection engine, Chalk, one of which no longer passes in the presence of the new library impls. Because Chalk lives out of tree, rust-lang/rust#86041 has no way to fix this other than performing a complete Chalk upgrade, which would be a broad undertaking that is out of scope for the PR. Instead, after asking in the #wg-traits channel ( https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/chalk.20ICE.20in.20rustc.20tests ), the decision was made to comment out the offending line until such time as Chalk is properly fixed and rustc has upgraded its dependency.

(Note: as of this writing rust-lang/rust#86041 is still open, but I've filed this now in order to have an issue number to put in the FIXME comment.)

@jackh726 jackh726 transferred this issue from rust-lang/rust Mar 21, 2022
@jackh726 jackh726 added C-chalk-solve Issues related to the chalk-solve crate and removed WG-traits labels Mar 21, 2022
@jackh726
Copy link
Member

I moved this to this repo; ultimately this is just Chalk work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-chalk-solve Issues related to the chalk-solve crate
Projects
None yet
Development

No branches or pull requests

2 participants