Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback to get layout data #518

Open
basil-cow opened this issue Jun 11, 2020 · 7 comments
Open

Add callback to get layout data #518

basil-cow opened this issue Jun 11, 2020 · 7 comments
Labels
C-chalk-ir Issues related to the chalk-ir crate C-chalk-solve Issues related to the chalk-solve crate good first issue A good issue to start working on Chalk with

Comments

@basil-cow
Copy link
Contributor

basil-cow commented Jun 11, 2020

To perform some of wf checks, we need access to type layout data. For now we need two things: alignment and whether or not a type is a ZST. Note that computing layout needs access to the environment, so the callback will need to accept it as a parameter.

@bjorn3
Copy link
Member

bjorn3 commented Jun 12, 2020

Which wf checks? Rust-analyzer doesn't calculate the layout of types and I don't think it will anytime soon.

@basil-cow
Copy link
Contributor Author

@bjorn3 DispatchFromDyn impl wf checks, link

@flodiebold
Copy link
Member

Rust-analyzer doesn't do any WF checking either though, so we can probably get away with a stub implementation of these callbacks.

@jackh726 jackh726 added the good first issue A good issue to start working on Chalk with label Jun 23, 2020
@jackh726 jackh726 added C-chalk-ir Issues related to the chalk-ir crate C-chalk-solve Issues related to the chalk-solve crate labels Dec 11, 2020
@vringar
Copy link

vringar commented Sep 21, 2021

@rustbot claim

Updated permalink

I still need to understand what needs to be done as part of this issue and if anybody has already done anything like this somewhere else.
If anybody wants to give hints in that regard, I welcome them.

@vringar
Copy link

vringar commented Sep 21, 2021

My first hunch would be that this method needs to be added to the WfSolver based on the other methods that are there.
Is that correct?

@JakobDegen
Copy link
Contributor

@vringar if you're no longer working on this, can I give it a go?

@vringar
Copy link

vringar commented Nov 2, 2021

Go ahead!

@vringar vringar removed their assignment Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-chalk-ir Issues related to the chalk-ir crate C-chalk-solve Issues related to the chalk-solve crate good first issue A good issue to start working on Chalk with
Projects
None yet
Development

No branches or pull requests

6 participants