From f7179c49ce6069328caf82cc16c67498f1f16095 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Tue, 20 Jan 2026 10:28:46 -0600 Subject: [PATCH 1/6] fix(rm): Improve lack of -p error message --- src/bin/cargo/commands/remove.rs | 9 +++++---- .../invalid_package_multiple/stderr.term.svg | 12 +++++++----- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/src/bin/cargo/commands/remove.rs b/src/bin/cargo/commands/remove.rs index 60979cae26f..db89768dfeb 100644 --- a/src/bin/cargo/commands/remove.rs +++ b/src/bin/cargo/commands/remove.rs @@ -75,7 +75,8 @@ pub fn exec(gctx: &mut GlobalContext, args: &ArgMatches) -> CliResult { 0 => { return Err(CliError::new( anyhow::format_err!( - "no packages selected to modify. Please specify one with `-p `" + "no package selected to modify +help: specify a package with `-p `" ), 101, )); @@ -85,9 +86,9 @@ pub fn exec(gctx: &mut GlobalContext, args: &ArgMatches) -> CliResult { let names = packages.iter().map(|p| p.name()).collect::>(); return Err(CliError::new( anyhow::format_err!( - "`cargo remove` could not determine which package to modify. \ - Use the `--package` option to specify a package. \n\ - available packages: {}", + "no package selected to modify +help: specify a package with `-p ` + available packages: {}", names.join(", ") ), 101, diff --git a/tests/testsuite/cargo_remove/invalid_package_multiple/stderr.term.svg b/tests/testsuite/cargo_remove/invalid_package_multiple/stderr.term.svg index b71403fa662..373bae6efb0 100644 --- a/tests/testsuite/cargo_remove/invalid_package_multiple/stderr.term.svg +++ b/tests/testsuite/cargo_remove/invalid_package_multiple/stderr.term.svg @@ -1,7 +1,7 @@ - +