Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test)!: Clarify extension trait role with rename #14269

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Jul 19, 2024

When browsing the docs, I feel like this will make it easier to tell the role of these traits within the API.
Or in other words, I can easily tell that these fill a support role and for what, so I know when I care to look into them.

We use this naming pattern for
cargo_test_support::paths::CargoPathExt.

When browsing the docs, I feel like this will make it easier to tell the
role of these traits within the API.
Or in other words, I can easily tell that these fill a support role and
for what, so I know when I care to look into them.

We use this naming pattern for
`cargo_test_support::paths::CargoPathExt`.
@rustbot
Copy link
Collaborator

rustbot commented Jul 19, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2024
@ehuss
Copy link
Contributor

ehuss commented Jul 19, 2024

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 19, 2024

📌 Commit a49921f has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2024
@bors
Copy link
Contributor

bors commented Jul 19, 2024

⌛ Testing commit a49921f with merge dad331c...

@bors
Copy link
Contributor

bors commented Jul 19, 2024

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing dad331c to master...

@bors bors merged commit dad331c into rust-lang:master Jul 19, 2024
22 checks passed
@epage epage deleted the test-ext branch July 19, 2024 15:54
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2024
Update cargo

9 commits in a2b58c3dad4d554ba01ed6c45c41ff85390560f2..5f6b9a92201d78af75dc24f14662c3e2dacbbbe1
2024-07-16 00:52:02 +0000 to 2024-07-19 18:09:17 +0000
- Add `TomlPackage::new`, `Default` for `TomlWorkspace` (rust-lang/cargo#14271)
- fix(test): Move 'cargo_home' from 'install' to 'paths' (rust-lang/cargo#14270)
- fix(test)!: Clarify extension trait role with rename (rust-lang/cargo#14269)
- feat(test): Re-export ProcessBuilder (rust-lang/cargo#14268)
- fix(test): Move path2url to CargoPathExt::to_url (rust-lang/cargo#14266)
- Fix passing of links-overrides with target-applies-to-host and an implicit target (rust-lang/cargo#14205)
- fix(toml): Improve error on missing package and workspace (rust-lang/cargo#14261)
- Migrate global_cache_tracker snapbox (rust-lang/cargo#14244)
- make summary sync by using Arc not Rc (rust-lang/cargo#14260)
@rustbot rustbot added this to the 1.82.0 milestone Jul 21, 2024
bors added a commit that referenced this pull request Jul 22, 2024
chore: bump cargo-test-support to 0.4.0

### What does this PR try to resolve?

These PRs have contributed to major changes:

* #14266
* #14269
* #14270

### How should we test and review this PR?

### Additional information

Error log:

```
    Checking cargo-test-support v0.3.0 -> v0.3.1 (minor change)
     Checked [   0.079s] 66 checks; 63 passed, 3 failed, 6 unnecessary

--- failure function_missing: pub fn removed or renamed ---

Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/function_missing.ron

Failed in:
  function cargo_test_support::install::cargo_home, previously in file /projects/cargo/target/semver-checks/git-a2b58c3dad4d554ba01ed6c45c41ff85390560f2/e5a046bb78236b6c7eddf006d3a5ac7b4a5593aa/crates/cargo-test-support/src/install.rs:27
  function cargo_test_support::path2url, previously in file /projects/cargo/target/semver-checks/git-a2b58c3dad4d554ba01ed6c45c41ff85390560f2/e5a046bb78236b6c7eddf006d3a5ac7b4a5593aa/crates/cargo-test-support/src/lib.rs:1187

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/struct_missing.ron

Failed in:
  struct cargo_test_support::RawOutput, previously in file /projects/cargo/target/semver-checks/git-a2b58c3dad4d554ba01ed6c45c41ff85390560f2/e5a046bb78236b6c7eddf006d3a5ac7b4a5593aa/crates/cargo-test-support/src/lib.rs:524

--- failure trait_missing: pub trait removed or renamed ---

Description:
A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/trait_missing.ron

Failed in:
  trait cargo_test_support::TestEnv, previously in file /projects/cargo/target/semver-checks/git-a2b58c3dad4d554ba01ed6c45c41ff85390560f2/e5a046bb78236b6c7eddf006d3a5ac7b4a5593aa/crates/cargo-test-support/src/lib.rs:1272
  trait cargo_test_support::prelude::TestEnv, previously in file /projects/cargo/target/semver-checks/git-a2b58c3dad4d554ba01ed6c45c41ff85390560f2/e5a046bb78236b6c7eddf006d3a5ac7b4a5593aa/crates/cargo-test-support/src/lib.rs:1272
  trait cargo_test_support::ChannelChanger, previously in file /projects/cargo/target/semver-checks/git-a2b58c3dad4d554ba01ed6c45c41ff85390560f2/e5a046bb78236b6c7eddf006d3a5ac7b4a5593aa/crates/cargo-test-support/src/lib.rs:1252
  trait cargo_test_support::prelude::ChannelChanger, previously in file /projects/cargo/target/semver-checks/git-a2b58c3dad4d554ba01ed6c45c41ff85390560f2/e5a046bb78236b6c7eddf006d3a5ac7b4a5593aa/crates/cargo-test-support/src/lib.rs:1252
  trait cargo_test_support::CargoCommand, previously in file /projects/cargo/target/semver-checks/git-a2b58c3dad4d554ba01ed6c45c41ff85390560f2/e5a046bb78236b6c7eddf006d3a5ac7b4a5593aa/crates/cargo-test-support/src/lib.rs:1388
  trait cargo_test_support::prelude::CargoCommand, previously in file /projects/cargo/target/semver-checks/git-a2b58c3dad4d554ba01ed6c45c41ff85390560f2/e5a046bb78236b6c7eddf006d3a5ac7b4a5593aa/crates/cargo-test-support/src/lib.rs:1388
  trait cargo_test_support::ArgLine, previously in file /projects/cargo/target/semver-checks/git-a2b58c3dad4d554ba01ed6c45c41ff85390560f2/e5a046bb78236b6c7eddf006d3a5ac7b4a5593aa/crates/cargo-test-support/src/lib.rs:1402
  trait cargo_test_support::prelude::ArgLine, previously in file /projects/cargo/target/semver-checks/git-a2b58c3dad4d554ba01ed6c45c41ff85390560f2/e5a046bb78236b6c7eddf006d3a5ac7b4a5593aa/crates/cargo-test-support/src/lib.rs:1402
     Summary semver requires new major version: 3 major and 0 minor checks failed
```
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jul 28, 2024
Update cargo

9 commits in a2b58c3dad4d554ba01ed6c45c41ff85390560f2..5f6b9a92201d78af75dc24f14662c3e2dacbbbe1
2024-07-16 00:52:02 +0000 to 2024-07-19 18:09:17 +0000
- Add `TomlPackage::new`, `Default` for `TomlWorkspace` (rust-lang/cargo#14271)
- fix(test): Move 'cargo_home' from 'install' to 'paths' (rust-lang/cargo#14270)
- fix(test)!: Clarify extension trait role with rename (rust-lang/cargo#14269)
- feat(test): Re-export ProcessBuilder (rust-lang/cargo#14268)
- fix(test): Move path2url to CargoPathExt::to_url (rust-lang/cargo#14266)
- Fix passing of links-overrides with target-applies-to-host and an implicit target (rust-lang/cargo#14205)
- fix(toml): Improve error on missing package and workspace (rust-lang/cargo#14261)
- Migrate global_cache_tracker snapbox (rust-lang/cargo#14244)
- make summary sync by using Arc not Rc (rust-lang/cargo#14260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing-cargo-itself Area: cargo's tests S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants