Limit exported-private-dependencies lints to libraries #13135
Conversation
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-build-execution
| @@ -246,3 +246,184 @@ fn workspace_dep_made_public() { | |||
| .masquerade_as_nightly_cargo(&["public-dependency"]) | |||
| .run() | |||
| } | |||
|
|
|||
| #[cargo_test(nightly, reason = "exported_private_dependencies lint is unstable")] | |||
| fn allow_priv_in_tests() { | |||
There was a problem hiding this comment.
Another one we should cover is build scripts.
There was a problem hiding this comment.
Looks like proc-macros are lib's but I'm assuming those shouldn't be checked with exported_private_dependencies.
Example libs are an odd case.
I'm more mixed about crate types, like cdylibs.
@ehuss any thoughts?
There was a problem hiding this comment.
Another one we should cover is build scripts.
OK, add a test for custom build script
There was a problem hiding this comment.
I think it would be good if all libs warn just like a normal rlib. Any lib type can expose types within item signatures, and it seems like it would be good hygiene to be explicit about that.
For proc-macros, it is not possible to have public items (other than the proc-macros themselves), so it is not possible to "leak" anything AFAIK. But I wouldn't go out of my way to try to disable it there.
There was a problem hiding this comment.
I'll go for that. We can always re-visit.
|
Thanks for doing this! Overall, looks good! |
linyihai
force-pushed
the
limit-priv-to-library
branch
from
2348ac2 to
ab13b10
Compare
|
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Update cargo 20 commits in 9787229614b27854cf73d57ffae430d7c1e6caa4..1aa9df1a5be205cce621f0bc0ea6062a5e22a98c 2023-12-06 02:29:23 +0000 to 2023-12-12 14:52:31 +0000 - crates-io: Add support for other 2xx HTTP status codes (rust-lang/cargo#13158) - Remove the deleted feature test_2018_feature from the test (rust-lang/cargo#13156) - refactor(schema): Remove reliance on cargo types (rust-lang/cargo#13154) - fix(toml)!: Disallow `[lints]` in virtual workspaces (rust-lang/cargo#13155) - Limit exported-private-dependencies lints to libraries (rust-lang/cargo#13135) - chore: update to [email protected] (rust-lang/cargo#13148) - Update curl-sys to bring in curl 8.5.0 (rust-lang/cargo#13147) - chore: downgrade to openssl v1.1.1 (rust-lang/cargo#13144) - fix: explicitly remap current dir by using `.` (rust-lang/cargo#13114) - Don't rely on mtime to test changes (rust-lang/cargo#13143) - refactor: Pull PackageIdSpec into schema (rust-lang/cargo#13128) - fix: Print rustc messages colored on wincon (rust-lang/cargo#13140) - Add a windows manifest file (rust-lang/cargo#13131) - Avoid writing CACHEDIR.TAG if it already exists (rust-lang/cargo#13132) - re-enable flaky tests thanks to update to `gix-config`. (rust-lang/cargo#11821) (rust-lang/cargo#13130) - fix bash completion in directory with spaces (rust-lang/cargo#13126) - test: re-ignore git auth tests for gitoxide (rust-lang/cargo#13129) - fix(toml): Disallow inheriting of dependency public status (rust-lang/cargo#13125) - re-enable previously disabled tests with Windows-specific fix (rust-lang/cargo#13117) - refactor: Clarify PackageId constructor names (rust-lang/cargo#13123)
What does this PR try to resolve?
Completed #13039.
This PR limit
exported-private-dependencieslint in librarayTarget.How should we test and review this PR?
Your can checkout out 2348ac2 and run test, it will failed and then it will be passed in the commit 2348ac2
Additional information