-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Backport #11630 to 1.69.0
#11806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nheritance (cherry picked from commit a32af2f)
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
|
rustbot
added
A-crate-dependencies
Area: [dependencies] of any kind
A-manifest
Area: Cargo.toml issues
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 6, 2023
weihanglo
approved these changes
Mar 7, 2023
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 7, 2023
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Mar 9, 2023
Bump crates-io to 0.36.0 This was an overlook of #11600 Since we already got #11806 to backport, I guess it is not harmful to <https://github.com/rust-lang/cargo/labels/beta-nominated> this as well. Maybe it do need a backport as `src/cargo/ops/registry.rs` use a new public API from that PR. BTW, please help check if it is really a breaking change.
bors
added a commit
that referenced
this pull request
Mar 9, 2023
Bump crates-io to 0.36.0 This was an overlook of #11600 Since we already got #11806 to backport, I guess it is not harmful to <https://github.com/rust-lang/cargo/labels/beta-nominated> this as well. Maybe it do need a backport as `src/cargo/ops/registry.rs` use a new public API from that PR. BTW, please help check if it is really a breaking change.
weihanglo
pushed a commit
to weihanglo/cargo
that referenced
this pull request
Mar 9, 2023
Bump crates-io to 0.36.0 This was an overlook of rust-lang#11600 Since we already got rust-lang#11806 to backport, I guess it is not harmful to <https://github.com/rust-lang/cargo/labels/beta-nominated> this as well. Maybe it do need a backport as `src/cargo/ops/registry.rs` use a new public API from that PR. BTW, please help check if it is really a breaking change.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2023
…nglo [beta-1.69] cargo beta backports 3 commits in 9880b408a3af50c08fab3dbf4aa2a972df71e951..7b18c85808a6b45ec8364bf730617b6f13e0f9f8 2023-02-28 19:39:39 +0000 to 2023-03-17 12:29:33 +0000 - [beta-1.69] backport rust-lang/cargo#11824 (rust-lang/cargo#11863) - [beta-1.69] backport rust-lang/cargo#11820 (rust-lang/cargo#11823) - chore: Backport rust-lang/cargo#11630 to `1.69.0` (rust-lang/cargo#11806) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-crate-dependencies
Area: [dependencies] of any kind
A-manifest
Area: Cargo.toml issues
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11630 was a fix for unused manifest keys not showing. It did not make it in before branching
1.69.0
. This backports that fix so it will be in1.69.0
Commits:
fix(toml): Provide a way to show unused manifest keys for workspace inheritance
(cherry picked from commit a32af2f)
Ref: rust-lang/rust#108665