Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --all to --workspace #6977

Closed
ehuss opened this issue May 23, 2019 · 3 comments · Fixed by #7241
Closed

Rename --all to --workspace #6977

ehuss opened this issue May 23, 2019 · 3 comments · Fixed by #7241

Comments

@ehuss
Copy link
Contributor

ehuss commented May 23, 2019

I have noticed that people occasionally get confused with the --all flag, usually confusing it with the --all-targets flag. I'd like to propose renaming it to --workspace which should better convey what the flag is for. We briefly discussed this in the team meeting and it seemed people were generally positive to the idea (and Josh came up with the best suggestion), so I'm opening this issue in case anyone watching this repo wants to provide feedback on the idea.

The --all flag would continue to work, but would be undocumented and deprecated and will probably issue a warning when used indicating the new flag name (maybe with a transition period with no warnings?).

@est31
Copy link
Member

est31 commented Aug 15, 2019

I like the shortness of --all. --workspace seems so long to type.

@est31
Copy link
Member

est31 commented Aug 15, 2019

What about adding a -wshorthand similar to how there is -p?

@k-nasa
Copy link
Contributor

k-nasa commented Aug 21, 2019

-w shortcuts are good.
how about @ehuss ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants