Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolver error messages should include the version requirements #6203

Closed
Eh2406 opened this issue Oct 22, 2018 · 1 comment
Closed

Resolver error messages should include the version requirements #6203

Eh2406 opened this issue Oct 22, 2018 · 1 comment
Labels
A-dependency-resolution Area: dependency resolution and the resolver A-diagnostics Area: Error and warning messages generated by Cargo itself.

Comments

@Eh2406
Copy link
Contributor

Eh2406 commented Oct 22, 2018

Currently if the resolver fails the error messages give lots of information on the paths that caused the problems, like:

cargo/tests/testsuite/build.rs

Lines 1356 to 1358 in 0b530c3

previously selected package `bad v1.0.0`
... which is depended on by `bar v0.1.0`
... which is depended on by `incompatible_dependencies v0.0.1 ([..])`

It would be nice to have the version requirements like: (wording needs improvement)

  previously selected package `bad v1.0.0`
    ... which is depended on by `bar v0.1.0` which requires `bad: "=1.0.0"`
    ... which is depended on by `incompatible_dependencies v0.0.1 ([..])` which requires `bar: "0.1.0"`

The data is easily available thanks to #5428 we just need to get it into the correct place, and find good wording. We almost had this working in #5402 before it bitroted.

I am willing to mentor someone on getting this done. It may be a good place to start looking at the resolver without having to stare into the void at its core. If it would be useful I can rebase #5452 so that only the wording is left.

cc @necaris would you be interested?

@Eh2406 Eh2406 added A-diagnostics Area: Error and warning messages generated by Cargo itself. E-help-wanted A-dependency-resolution Area: dependency resolution and the resolver labels Oct 22, 2018
@Eh2406 Eh2406 closed this as completed Oct 22, 2018
@rust-lang rust-lang locked and limited conversation to collaborators Oct 22, 2018
@dwijnand
Copy link
Member

Duplicate of #6199

@dwijnand dwijnand marked this as a duplicate of #6199 Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-dependency-resolution Area: dependency resolution and the resolver A-diagnostics Area: Error and warning messages generated by Cargo itself.
Projects
None yet
Development

No branches or pull requests

2 participants