-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo should use progress bar only on terminals that support it #5721
Comments
I think that Travis intentionally sets Note: The progress bar has been placed behind an unstable option in #5716, so it will go away the next time cargo is updated in nightly. Edit: Also, Travis sets up scripts with a tty. |
Oh crap, then cargo cannot really detect this. If there was an environment variable, one could disable the progress bar without having to change the TERM.
Sad to hear this, i've enjoyed it a lot today :/ |
So one could argue that the bug is really on the Travis side for setting |
Yes, but this is no excuse for A workaround could be for
|
I agree there probably should be some way to disable it. Does anyone at @rust-lang/cargo have any opinions about this, and how to approach it?
|
I think that having such an environment variable would be useful irrespectively of what's done about the other options. |
This seems good to me, like the most general option and already an established 'standard'.
I have a bad opinion of env vars in general (they are global mutable state) and I'd much prefer to use a command line option (if the CI env var is not good enough). |
👍 for the If push comes to shove we could also have a |
Oh one thing I should mention on the cli/env/config var debate is that one thing I've intended we should do for a long time is to add a |
(there's now a proposal for that in #6699) |
I'm going to close this as fixed. #6281 disabled the progress bar when |
FWIW, |
So does cargo, see |
@ehuss |
Thank you, @Luchanso. That is an interesting idea. There are already some discussion around console output happening. You can check the label
A-console-output
As your proposal seems like a new feature request, to catch everyone's eyes, I would suggest commenting on a relevant open issue or creating your own, rather than replying under a closed issue :) |
Currently cargo seems to always use a progress bar, but for example the terminal that travis uses does not support it, such that every update to the progress bar creates a lot of noise: https://api.travis-ci.org/v3/job/403149958/log.txt
Cargo should detect whether the terminal allows modifying a line in place, and if it doesn't, it shouldn't really use a progress bar.
Also, there should be an environment variable that allows disabling the progress bar, but I couldn't find one in the cargo book. So maybe the docs need updating, or if there isn't one, we maybe should add one.
Also, kudos to whoever added the progress bar, been using it all day, and its really nice, so thanks for doing that!
The text was updated successfully, but these errors were encountered: