Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bit-set 0.2.0 compilation failed #13824

Closed
positiveway opened this issue Apr 29, 2024 · 5 comments
Closed

bit-set 0.2.0 compilation failed #13824

positiveway opened this issue Apr 29, 2024 · 5 comments
Labels
A-crate-dependencies Area: [dependencies] of any kind C-bug Category: bug S-triage Status: This issue is waiting on initial triage.

Comments

@positiveway
Copy link

Problem

#9885
Same issue reappeared with bit-set v.0.2.0 dependency of libusb on nightly 1.80.0 (maybe even on 1.79, it was ok last time I checked 2 weeks ago)

Steps

No response

Possible Solution(s)

No response

Notes

No response

Version

No response

@positiveway positiveway added C-bug Category: bug S-triage Status: This issue is waiting on initial triage. labels Apr 29, 2024
@heisen-li
Copy link
Contributor

@rustbot label +A-crate-dependencies

@rustbot rustbot added the A-crate-dependencies Area: [dependencies] of any kind label Apr 29, 2024
@heisen-li
Copy link
Contributor

@epage
Copy link
Contributor

epage commented Apr 29, 2024

This has had a "we'll break this in the future" message for 2.5 years (though not elevated for dependents to see). The last bit-set version with this problem was 0.3.0 and was released 8 years ago with the fix in 0.4.0 was also released 8 years ago. There have been 4 newer versions since then.

Of the 93 direct dependents, the following are the only ones where the latest version still depends on a "bad" version of bit-set:

Looking at their recent download counts, they are fairly low, with the "most popular" hovering around 150/day

libusb has had two PRs for addressing this (directly or indirectly) since 2017 and 2021

@epage
Copy link
Contributor

epage commented Apr 30, 2024

We talked about this in today's meeting.

We are planning to keep this as-is because

  • This was a bug
  • We started notifying several years ago about this
  • Newer versions of the package are fixed and this is a problem with an unmaintained dependent
    • There seem to be maintained, more popular replacements in the form of rusb which had a release just 3 days ago and has 6x the total downloads

@tanriol
Copy link

tanriol commented Aug 20, 2024

I want to note that the error message here is less useful than usual - it tells me about the problematic crate, but does not tell me how it got pulled in, and cargo tree -i bit-set just produces the same error again without any additional information, so I need to look in Cargo.lock manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-crate-dependencies Area: [dependencies] of any kind C-bug Category: bug S-triage Status: This issue is waiting on initial triage.
Projects
None yet
Development

No branches or pull requests

5 participants