Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UncanonicalizedIter generates invalid paths #11935

Closed
ehuss opened this issue Apr 5, 2023 · 0 comments · Fixed by #11936
Closed

UncanonicalizedIter generates invalid paths #11935

ehuss opened this issue Apr 5, 2023 · 0 comments · Fixed by #11936
Assignees
Labels
A-dependency-resolution Area: dependency resolution and the resolver A-registries Area: registries

Comments

@ehuss
Copy link
Contributor

ehuss commented Apr 5, 2023

UncanonicalizedIter can generate invalid paths if the path has a dash or hyphen within the first 4 characters.

Example, my-tool produces:

  • my/-t/my-tool
  • my/_t/my-tool
  • my/-t/my_tool
  • my/_t/my_tool

The second and third paths are invalid because the directory prefix does not match the name of the file.

I think the UncanonicalizedIter needs to iterate over the fs_name before it has been converted to path.

@ehuss ehuss added A-dependency-resolution Area: dependency resolution and the resolver A-registries Area: registries labels Apr 5, 2023
@ehuss ehuss self-assigned this Apr 5, 2023
@bors bors closed this as completed in 41f7888 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependency-resolution Area: dependency resolution and the resolver A-registries Area: registries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant