Cargo test ignores test flags when testing specific keyword

[dist1ll]

Problem

When running cargo test xyz, cargo ignores all test flags in the cargo.toml file.

Steps

1. create project cargo init xyz
2. add #[test] fn random{} to your main.rs
3. add the following to your Cargo.toml

[[bin]]
name = "main"
path = "src/main.rs"
test = false

4. type cargo test and then type cargo test xyz

Result:

Possible Solution(s)

No response

Notes

No response

Version

cargo 1.59.0-nightly (358e79fe5 2022-01-04)

[weihanglo]

I guess it's #6683 that causes the compilation not respecting the default target selection rules. In contrast, it compiles all bin and test targets in order to filter unit tests. Is this a desired change?

Personally I feel like when running cargo test [testname] without specifying targets, cargo should always compile the default targets. The alternative solution is reusing the logic of CompileFilter to determine which target is required to run in ops::run_tests, but it don't feel good in this way.

[dist1ll]

What do you mean by "cargo should always compile the default targets"? (I'm not so familiar with the lingo)

I don't think cargo test [testname] should compile more than cargo test. I put test = false because I don't want to test that target. What other reason could exist to add test = false in your .toml

I rarely use cargo test when developing, only once before a commit. cargo test [testname] on the other hand is done in a much tighter loop.

[weihanglo]

Each build command in cargo has its own target selection rule. For example, cargo test by default compiles and runs unit tests under bins, tests, and lib with respecting your target settings (test = ture|false in Cargo.toml).
Your concern is valid, when you execute cargo test [testname] it behaves like compiling and running unit tests under all bins, tests, and lib targets no matter what is set in Cargo.toml. That's what #6683 did. I'm unsure if it is expected.

[ehuss]

I think in this particular situation, it probably shouldn't be building the test=false entries.

It might be a little tricky code-wise. Cargo allows you to override the test=false by specifying the test specifically (like cargo test --test foo. However, I think this shouldn't be too hard to fix.