Commit 88411f4
authored
fix(completions): don't wrap completion item help in parenthesis (#16215)
### What does this PR try to resolve?
Fish shell automatically wraps the help text in parenthesis, so this wil
result in them being applied twice.
<img width="1426" height="197" alt="image"
src="https://github.com/user-attachments/assets/cc9529b3-beb4-473d-908a-7f467b6bb4bf"
/>
On zsh it previously looked like this
```
--target-dir -- Directory for all generated artifacts
--timings -- Timing output formats (unstable) (comma separated): html, json
--unit-graph -- Output build graph in JSON (unstable)
--verbose -- Use verbose output (-vv very verbose/build.rs output)
-Z -- Unstable (nightly-only) flags to Cargo, see 'cargo -Z help' for details
fix-json -- (from rustfix)
matches -- (from cargo-platform)
stdout-redirected file-provider -- (from cargo-credential)
```
and will now be
```
fix-json -- from rustfix
matches -- from cargo-platform
stdout-redirected file-provider -- from cargo-credential
```
Bash doesn't show the help text at all so it doesn't matter.1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1218 | 1218 | | |
1219 | 1219 | | |
1220 | 1220 | | |
1221 | | - | |
| 1221 | + | |
1222 | 1222 | | |
1223 | 1223 | | |
1224 | 1224 | | |
| |||
1243 | 1243 | | |
1244 | 1244 | | |
1245 | 1245 | | |
1246 | | - | |
| 1246 | + | |
1247 | 1247 | | |
1248 | 1248 | | |
1249 | 1249 | | |
| |||
0 commit comments