Ch 3 edits #121
Ch 3 edits #121
Conversation
|
Just rebased to get the changes made in #119 incorporated here :) |
| Inside the function body, we added the following: | ||
|
|
||
| ```rust,ignore | ||
| let x = 5; |
There was a problem hiding this comment.
I wonder if this indent should be here or not. Hm.
There was a problem hiding this comment.
It looks kinda weird in the rendered HTML... I'mma take it out.
|
Looks wonderful. I have a few tiny nits/comments |
Fix some parts that didn't make sense anymore since I moved data structures before this section-- tuples and destructuring have already been defined.
I added a bit about the other style of comments being possible since it's preferred for accessibility reasons: rust-lang/rfcs#1574 (comment)
Bad text editor. Not helpful. No.
|
Sorry, it doesn't actually take me an hour to rebase, I got distracted 😅 Anyone else want to review before merging this? @aturon or @jonathandturner maybe? |
|
@carols10cents I will try to get to it today if at all possible! |
|
|
||
| ### Keywords | ||
|
|
||
| First, keep in mind that the Rust language has a set of *keywords* that have |
There was a problem hiding this comment.
This feels like a pretty big tangent, especially so early on in the book. Is there any way we can at least put the list itself into an appendix (that we link to)?
|
Closing this because I've merged it into the first-third-try branch, which will get merged eventually. |
What I did to create this PR was:
src/ch03-*files.Keeping in mind that we're trying to cover the most important essentials at this stage in a person's rust education, I did remove a few sections that covered subtleties that, imo, are not super important to get into in chapter 3, like
mutapplying to the binding, not the value.I'd love any thoughts or feedback from anyone!