Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

stable dist choked on artifact consolidation #154

Closed
xen0n opened this issue Feb 7, 2017 · 4 comments
Closed

stable dist choked on artifact consolidation #154

xen0n opened this issue Feb 7, 2017 · 4 comments

Comments

@xen0n
Copy link

xen0n commented Feb 7, 2017

Example.

Reason is multiple files with the same name inside the different source directories; we need to filter them somehow. Particularly the rust-src tarballs and maybe docs? A ls -R should be helpful.

@brson
Copy link
Contributor

brson commented Feb 7, 2017

The problem here I think is that rustbuild is not cleaning up the dist directory before running dist.

The collisions are with 1.15.0 on a build of 1.15.1. These are stale binaries just sitting on the mac builders. Only happens with macs because other platforms run in clean containers.

@brson
Copy link
Contributor

brson commented Feb 7, 2017

Nightly and beta produce artifacts that are not differentiated by the name, which is why we didn't see it until a stable release.

@xen0n
Copy link
Author

xen0n commented Feb 7, 2017

Hmm, the explanation makes sense! Manually cleaning the dist dirs of the mac builders and re-triggering a packaging step somehow should fix packaging then.

@brson
Copy link
Contributor

brson commented Feb 7, 2017

Fixed on master by rust-lang/rust#39622. Fixed on stable by logging into the build slaves and cleaning manually.

@brson brson closed this as completed Feb 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants