Skip to content

Commit

Permalink
Update new target check-cfg instructions
Browse files Browse the repository at this point in the history
  • Loading branch information
Urgau authored and tshepang committed Jul 1, 2024
1 parent 98c5f27 commit d6e3a32
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions src/building/new-target.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,18 @@ unexpected because stage0 doesn't know about the new target specification and
we pass `--check-cfg` in order to tell it to check.

To fix the errors you will need to manually add the unexpected value to the
`EXTRA_CHECK_CFGS` list in `src/bootstrap/src/lib.rs`. Here is an example for
adding `NEW_TARGET_OS` as `target_os`:
different `Cargo.toml` in `library/{std,alloc,core}/Cargo.toml`. Here is an
example for adding `NEW_TARGET_ARCH` as `target_arch`:

*`library/std/Cargo.toml`*:
```diff
- (Some(Mode::Std), "target_os", Some(&["watchos"])),
+ // #[cfg(bootstrap)] NEW_TARGET_OS
+ (Some(Mode::Std), "target_os", Some(&["watchos", "NEW_TARGET_OS"])),
[lints.rust.unexpected_cfgs]
level = "warn"
check-cfg = [
'cfg(bootstrap)',
- 'cfg(target_arch, values("xtensa"))',
+ # #[cfg(bootstrap)] NEW_TARGET_ARCH
+ 'cfg(target_arch, values("xtensa", "NEW_TARGET_ARCH"))',
```

To use this target in bootstrap, we need to explicitly add the target triple to the `STAGE0_MISSING_TARGETS`
Expand Down

0 comments on commit d6e3a32

Please sign in to comment.