Skip to content

Commit d45739b

Browse files
authored
Unrolled build for rust-lang#132182
Rollup merge of rust-lang#132182 - jieyouxu:downgrade-untranslatable, r=compiler-errors Downgrade `untranslatable_diagnostic` and `diagnostic_outside_of_impl` to `allow` Current implementation of translatable diagnostics infrastructure unfortunately causes some friction for compiler contributors. While we don't have a redesign that causes less friction in place, let's downgrade the internal `untranslatable_diagnostic` and `diagnostic_outside_of_impl` lints so we don't indicate to contributors that they *have* to use the current translation infra. I purposefully left `#[allow(untranslatable_diagnostic)]` and `#[allow(diagnostic_outside_of_impl)]` instances untouched because that seems like unnecessary additional churn. See <rust-lang#132181> for context. r? `@davidtwco` (or wg-diagnostics/compiler)
2 parents 4d88de2 + 5f47391 commit d45739b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

compiler/rustc_lint/src/internal.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ declare_tool_lint! {
427427
/// More details on translatable diagnostics can be found
428428
/// [here](https://rustc-dev-guide.rust-lang.org/diagnostics/translation.html).
429429
pub rustc::UNTRANSLATABLE_DIAGNOSTIC,
430-
Deny,
430+
Allow,
431431
"prevent creation of diagnostics which cannot be translated",
432432
report_in_external_macro: true,
433433
@eval_always = true
@@ -441,7 +441,7 @@ declare_tool_lint! {
441441
/// More details on diagnostics implementations can be found
442442
/// [here](https://rustc-dev-guide.rust-lang.org/diagnostics/diagnostic-structs.html).
443443
pub rustc::DIAGNOSTIC_OUTSIDE_OF_IMPL,
444-
Deny,
444+
Allow,
445445
"prevent diagnostic creation outside of `Diagnostic`/`Subdiagnostic`/`LintDiagnostic` impls",
446446
report_in_external_macro: true,
447447
@eval_always = true

0 commit comments

Comments
 (0)