You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It originated in #740 (From should be prefered to Into implementation as the first gives the second but it's not true the other way) where I said #740 (comment)
I don't see a point of not doing it so I suggest you convert it to a From implementation in a separate commit.
EDIT: After searching, it originated in #327 and nobody said it should not be From instead.
A fallible method of converting EitherOrBoth into an Either would be very useful providing exclusive (not including Both variant) methods. Converting should probably wait for rust-lang/rust#33417.
So I guess the question is: Instead of Into<Option<_>>, do we want a TryFrom or a From implementation?
I would vote for From (better than Into, no breaking change) over TryFrom (breaking change, what kind of error?).
itertools/src/either_or_both.rs
Lines 503 to 511 in 5a5731c
The text was updated successfully, but these errors were encountered: