From b9d9a499c6451d054b24ac7247ecb599077da41b Mon Sep 17 00:00:00 2001 From: Daniel Egger Date: Sun, 5 Jul 2020 14:20:00 +0200 Subject: [PATCH] Get rid of a boatload of unnecessary braces errors ``` warning: unnecessary braces around block return value --> src/lib.rs:22188:62 | 22188 | pub fn variant ( self , variant : HSEBYP_A ) -> & 'a mut W { { self . bit ( variant . into ( ) ) } } # [ doc = "HSE crystal oscillator not bypassed" ] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these braces ``` Signed-off-by: Daniel Egger --- src/generate/register.rs | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/src/generate/register.rs b/src/generate/register.rs index 5bba775f..3a50f7a1 100644 --- a/src/generate/register.rs +++ b/src/generate/register.rs @@ -499,15 +499,25 @@ pub fn fields( } } - proxy_items.extend(quote! { - ///Writes `variant` to the field - #inline - pub fn variant(self, variant: #pc_w) -> &'a mut W { - #unsafety { - self.#bits(variant.into()) + if unsafety.is_some() { + proxy_items.extend(quote! { + ///Writes `variant` to the field + #inline + pub fn variant(self, variant: #pc_w) -> &'a mut W { + unsafe { + self.#bits(variant.into()) + } } - } - }); + }); + } else { + proxy_items.extend(quote! { + ///Writes `variant` to the field + #inline + pub fn variant(self, variant: #pc_w) -> &'a mut W { + self.#bits(variant.into()) + } + }); + } for v in &variants { let pc = &v.pc;