-
Notifications
You must be signed in to change notification settings - Fork 63
switch to GH actions #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to GH actions #133
Conversation
|
You can see a preview of the action running on my branch: https://github.com/MarcoIeni/svd/actions |
|
bors try |
One thing that Other than that, LGTM 👍 |
|
I think we have to change this: Line 2 in 051e0b2
|
If we are not using it at the moment we can remove the |
|
cc @therealprof |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the conventions outlined in https://github.com/rust-embedded/wg/blob/master/ops/post-transfer.md
Specifically the trigger rules and bors.toml are not sufficient yet.
I completely removed the EDIT: I saw therealprof comment, I will do it today! |
|
@therealprof can you check bors settings/permissions for this repo? |
tryTimed out. |
Can do but I think it should work already just fine. |
|
Should I remove |
Don't bother. Doesn't do any harm. |
|
Mind squashing your commits? |
|
Done! |
|
Having separate commits can be very useful so auto-squashing is not a good idea. |
therealprof
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
bors r+
|
Build succeeded: |
Closes #132
Questions: