Implement LLVM intrinsics for Div and Mod so that / and % work "normally" on the GBA

[Lokathor]

So, if we implement the correct special function, then we can make code like

let a = x / y;

Will suddenly magically work on the GBA.

#[no_mangle] extern "aapcs" fn __aeabi_uidiv(num: u32: denom: u32) -> u32
#[no_mangle] extern "aapcs" fn __aeabi_idiv(num: i32: denom: i32) -> u32

Question

Do we want division to magically work like that?

Personally, I think that division is so damn costly on the GBA that I want it to be called as a special function or even as a macro (which makes it look a little weird) just so that people remember that they're doing a weird and costly operation.

[Lokathor]

Upon further chats on the discord, I'm convinced that it'll be fine to make normal division work via special intrinsic magic, so we'll mark this as Enhancement

[Lokathor]

So, due to reasons that no one can seem to figure out, LLVM just doesn't wanna play nice with the intrinsics here. It inserts calls to count zeroes and even if we try to implement that then it says it can't find it and no one was sure what was up.

So we'll put in the GBA BIOS call for i32/i32 divMod for now:

/// BIOS Call: Div (GBA SWI 0x06).
///
/// Gives both the DIV and MOD output of `numerator / denominator`.
///
/// # Panics
///
/// If `denominator` is 0.
#[inline]
pub fn div_modulus(numerator: i32, denominator: i32) -> (i32, i32) {
  assert!(denominator != 0);
  let div_out: i32;
  let mod_out: i32;
  unsafe {
    asm!(/* assembly template */ "swi 0x06"
        :/* output operands */ "={r0}"(div_out), "={r1}"(mod_out)
        :/* input operands */ "{r0}"(numerator), "{r1}"(denominator)
        :/* clobbers */ "r3"
        :/* options */
    );
  }
  (div_out, mod_out)
}

And we'll have to get back to mapping that (and anything else) into LLVM intrinsic stuff later.

[Lokathor]

Commented on the rustc issue for this

rust-lang/compiler-builtins#260

Hopefully we can get this done easily enough

[Lokathor]

Put in the start of a PR: rust-lang/compiler-builtins#267

[Lokathor]

Also we now have software versions for u32/u32 and i32/i32, so we can avoid the BIOS calls entirely, which should save us a big pile of overhead.

[Lokathor]

Oh yeah, the PR was merged and also the update made its way all the way to rustc

now that we can count leading zeroes, we still need division

[Lokathor]

I think we did this forever ago.