Add pub(crate) support

[richard-uk1]

Adds pub(crate) support where pub support is present in macros.rs.

[richard-uk1]

Currently there are no extra tests - I'll see if I can add some.

[coveralls]

Coverage decreased (-0.03%) to 88.051% when pulling 34b8739 on derekdreery:pub_crate into 460041a on Geal:master.

[coveralls]

Coverage decreased (-0.03%) to 88.051% when pulling 34b8739 on derekdreery:pub_crate into 460041a on Geal:master.

[coveralls]

Coverage increased (+0.02%) to 88.1% when pulling 34b8739 on derekdreery:pub_crate into 460041a on Geal:master.

[Geal]

hi! apparently the test cannot compile on current stable. IIRC that feature is still experimental, right?

[richard-uk1]

Aah I thought it was already stable. You are correct. Can I mark this PR as blocked by upstream until the syntax becomes stable?

[richard-uk1]

I've tested and it works on beta - not stable.. I think it was stabilized in 1.19, but maybe there are some changes in macros to support it in 1.20. Anyway, all tests pass in 1.20, so when that's released this should be mergeable.

[richard-uk1]

1.20 has been released now, so this should work

EDIT 1.20 is in beta.

The reason this will not build with 1.19 is not because pub(restricted) is missing (it isn't), but because there are bugs in the macro code that are fixed in 1.20.

[richard-uk1]

Version 1.20 is out, so this should no longer be blocked. I need to trigger a ci reload.

[coveralls]

Coverage increased (+0.02%) to 88.1% when pulling 1172238 on derekdreery:pub_crate into 460041a on Geal:master.

[richard-uk1]

I think there's an unstable 'vis' identifier, that would make all these variants unnecessary

[coveralls]

Coverage decreased (-0.1%) to 87.931% when pulling d384fba on derekdreery:pub_crate into 460041a on Geal:master.

[CAD97]

Tracking issue for :vis macro matcher

Seems to be almost en route to stabilization.

[Geal]

Thank you! This is getting in nom at last :)

[richard-uk1]

Note that this PR doesn't actually use :vis, it duplicates the code for the different varieties. the code could be reduced considerably by using the now-stabilized :vis macro ident type.