Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(no_std): boxed not in collections #537

Merged
merged 1 commit into from
Nov 25, 2017

Conversation

kamarkiewicz
Copy link
Contributor

This fixes just a basic compilation without std feature on current nightly channel. More work has to be done to adjust parsers to no_std.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 87.962% when pulling 7a99600 on kamarkiewicz:boxed-in-alloc into 56d0acc on Geal:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 87.962% when pulling 7a99600 on kamarkiewicz:boxed-in-alloc into 56d0acc on Geal:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 87.962% when pulling 7a99600 on kamarkiewicz:boxed-in-alloc into 56d0acc on Geal:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 87.962% when pulling 6fc2f34 on kamarkiewicz:boxed-in-alloc into 56d0acc on Geal:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 87.962% when pulling 6fc2f34 on kamarkiewicz:boxed-in-alloc into 56d0acc on Geal:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 87.962% when pulling 6fc2f34 on kamarkiewicz:boxed-in-alloc into 56d0acc on Geal:master.

@Geal
Copy link
Collaborator

Geal commented Jul 16, 2017

when was boxed moved out?

@kamarkiewicz
Copy link
Contributor Author

Please take a look here. Last working nightly version where build command is cargo build --no-default-features is rustc 1.19.0-nightly (554c685b0 2017-06-14)

@kamarkiewicz
Copy link
Contributor Author

Relevant issues in rust compiler are rust-lang/rust#27700 and rust-lang/rust#27783

@Geal
Copy link
Collaborator

Geal commented Oct 30, 2017

merged in the "result" branch for nom 4.0

@Geal Geal added this to the 4.0 milestone Oct 30, 2017
@Geal Geal merged commit 6fc2f34 into rust-bakery:master Nov 25, 2017
@kamarkiewicz kamarkiewicz deleted the boxed-in-alloc branch December 5, 2017 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants