feat: Complete derive helper attributes #18604
Conversation
rustbot
added
the
S-waiting-on-review
| let derive_helpers = annotated_item_kind | ||
| .filter(|kind| { | ||
| matches!( | ||
| kind, | ||
| SyntaxKind::STRUCT | ||
| | SyntaxKind::ENUM | ||
| | SyntaxKind::UNION | ||
| | SyntaxKind::VARIANT | ||
| | SyntaxKind::TUPLE_FIELD | ||
| | SyntaxKind::RECORD_FIELD | ||
| ) | ||
| }) |
There was a problem hiding this comment.
These could be used within the type specifications within ADTs as well, as in struct T { field: fn(#[helper] ()) } if I am not mistaken, though this is good enough
There was a problem hiding this comment.
I just checked and that's not true.
There was a problem hiding this comment.
It does work, but no one ever does this. rustfmt even drops the attribute in the function pointer param. So either way this is good enough
There was a problem hiding this comment.
Ah I thought you mean the opposite - that the attribute is not a helper but completed as such.
Empty attributes have a broken parse tree, so thats likely why #18608 will fix that |
Only their names, anything can go inside.
ChayimFriedman2
force-pushed
the
complete-helpers
branch
from
091a454 to
890d155
Compare
Only their names, anything can go inside.
Closes #18588.
This only completes when you type the first letter, I don't know why...