Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wheel for 3.13? #124

Closed
baseplate-admin opened this issue Aug 12, 2024 · 13 comments
Closed

Add wheel for 3.13? #124

baseplate-admin opened this issue Aug 12, 2024 · 13 comments

Comments

@baseplate-admin
Copy link
Contributor

Hi, it seems the 3.13 is soon to launch. Do you have any plans to release for 3.13?

@baseplate-admin
Copy link
Contributor Author

At the same time support for 3.7, 3.8 can be dropped

@baseplate-admin
Copy link
Contributor Author

Hi, @rushter , sorry for ping but can you please release it?

Now that python 3.13 is on the horizon?

@rushter
Copy link
Owner

rushter commented Oct 8, 2024

Python 3.13 is not available on CI yet.

https://github.com/rushter/selectolax/actions/runs/11236017337

@baseplate-admin
Copy link
Contributor Author

This is weird, cause of this: https://github.com/actions/python-versions/releases

It has 3.13.0

@rushter
Copy link
Owner

rushter commented Oct 8, 2024

@baseplate-admin
Copy link
Contributor Author

@rushter
Copy link
Owner

rushter commented Oct 8, 2024

In order to make a new release, we need to make sure that nothing breaks when switching to Cython 3.0.
https://cython.readthedocs.io/en/latest/src/userguide/migrating_to_cy30.html

@rushter
Copy link
Owner

rushter commented Oct 8, 2024

Build fails for Windows, will investigate it later https://github.com/rushter/selectolax/actions/runs/11239896149/job/31248003297

@char101
Copy link

char101 commented Oct 9, 2024

pip wheel uses a virtual env to build and does not use the existing cython. Using pip install setuptools && python setup.py bdist_wheel works.

@rushter
Copy link
Owner

rushter commented Oct 9, 2024

@char101 Are you sure? We had no problems previously

@char101
Copy link

char101 commented Oct 9, 2024

I just clone the repo previously.

First I built using setuptools, no problem.

And then I removed the cython generated .c source, then run pip wheel . which resulted in failure due to parser.c not found.

The only difference I can see is that pip wheel . is running setuptools in a venv.

Edit: I just clone the repo again and run pip wheel . and it run without problem. Must be something wrong with my setup previously.

Edit2: I think I found the problem. When my pip wheel . command failed, I didn't install the wheel package. When my pip wheel . command succeded, I have installed the wheel package. Looking at the changelog of cibuildwheel (or pip), it seems that the wheel package is no longer pinned as a dependency, so you have to install it manually.

@rushter
Copy link
Owner

rushter commented Oct 9, 2024

@char101 Thank you, it helped.

@baseplate-admin
Copy link
Contributor Author

Closing as completed.

Thanks: @rushter , @char101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants