Skip to content

Conversation

@groyoh
Copy link

@groyoh groyoh commented Nov 18, 2015

No description provided.

@bf4
Copy link

bf4 commented Nov 30, 2015

Is this repo meant as a hard fork of https://github.com/rails-api/active_model_serializers ? We could use the input over there :)

@groyoh
Copy link
Author

groyoh commented Nov 30, 2015

@bf4 you're right. We had to implement some missing features (concerning JSONAPI and namespacing mainly) and tried to get it back upstream (e.g. rails-api#1196). Unfortunately, things never seemed to move there so we decided to keep on adding things here that were not in the original repo. And at some point, a lot of interesting things were added at once upstream and we did not have time to catch up and sync with theses changes.

@bf4
Copy link

bf4 commented Nov 30, 2015

Well, let me know and I'll help get you back on ams prime :)

B mobile phone

On Nov 30, 2015, at 3:21 AM, Yohan Robert [email protected] wrote:

@bf4 you're right. We had to implement some missing features (concerning JSONAPI and namespacing mainly) and tried to get it back upstream (e.g. rails-api#1196). Unfortunately, things never seemed to move there so we decided to keep on adding things here that were not in the original repo. And at some point, a lot of interesting things were added at once upstream and we did not have time to catch up and sync with theses changes.


Reply to this email directly or view it on GitHub.

designrubenz added a commit that referenced this pull request Dec 2, 2015
@designrubenz designrubenz merged commit ee52c18 into master Dec 2, 2015
@bf4
Copy link

bf4 commented Dec 26, 2015

@groyoh @designrubenz would you mind making an issue to integrate with rails-api/active_model_serializers? I'd love to share ownership :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently set our travis to jruby-9000 and was surprised to see it running 9.0.0.0.pre1. I'm curious if you had any issues with JRuby 9k or specifying the version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue we saw were some randomly failling specs that I assume were due to some caching issues in the specs (this might be fixed upstream though). After retrying them, the specs would then pass.

As a side note, we haven't use jruby-9000 in production yet. We might do so in the first quarter of 2016 but in development AMS works pretty fine.

@groyoh
Copy link
Author

groyoh commented Dec 26, 2015

@bf4 glad to hear 😀 We've already planned to integrate it soon. I'll create an issue and let you know once it's done.

@groyoh groyoh deleted the update_travis branch December 26, 2015 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants