-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(checkout-strategy): On merge
strategy, reclone when necessary on base update
#3187
Merged
nitrocode
merged 8 commits into
runatlantis:main
from
finnag:reclone-on-merge-base-update
Mar 25, 2023
Merged
fix(checkout-strategy): On merge
strategy, reclone when necessary on base update
#3187
nitrocode
merged 8 commits into
runatlantis:main
from
finnag:reclone-on-merge-base-update
Mar 25, 2023
Commits on Mar 3, 2023
-
merge again if base branch has been updated
The current "merge" checkout strategy is unsafe. It merges the PR and the base branch without holding the directory lock(s), so there is a potentially very long window where another PR can be applied and be unexpectedly reverted later. This happens occasionally if a PR causes plans in multiple directories, but is almost _guaranteed_ to happen if the initial plan has to wait until a lock is freed up and a manual "atlantis plan" command is given. Instead of printing a warning when this happens, we now merge again if necessary while holding the lock. Plans are then guaranteed to only be made when merged with the base branch for each directory being planned, and applying later should be safe even if the base branch sees further updates. This fixes/affects runatlantis#804, runatlantis#867, runatlantis#979
Configuration menu - View commit details
-
Copy full SHA for 2bb1442 - Browse repository at this point
Copy the full SHA 2bb1442View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66a6771 - Browse repository at this point
Copy the full SHA 66a6771View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bdbf25 - Browse repository at this point
Copy the full SHA 3bdbf25View commit details
Commits on Mar 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7fad72e - Browse repository at this point
Copy the full SHA 7fad72eView commit details
Commits on Mar 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e40cc54 - Browse repository at this point
Copy the full SHA e40cc54View commit details
Commits on Mar 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2094383 - Browse repository at this point
Copy the full SHA 2094383View commit details
Commits on Mar 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f4c0f2c - Browse repository at this point
Copy the full SHA f4c0f2cView commit details -
Extend TestClone_MasterHasDiverged to test new merging functionality
We now verify that the first Clone with CheckoutMerge=true with a diverged base branch atually clones and merges again.
Configuration menu - View commit details
-
Copy full SHA for 50b3388 - Browse repository at this point
Copy the full SHA 50b3388View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.