Use custom ngrok config so we can specify api url. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a config file so we can set ngrok's API port (web_addr). We use the API to get the public URL and if there's already ngrok running, it will just choose a random API port and we won't be able to get the right url.
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
=======================================
Coverage 63.78% 63.78%
=======================================
Files 40 40
Lines 1955 1955
=======================================
Hits 1247 1247
Misses 644 644
Partials 64 64Continue to review full report at Codecov.
|
msarvar
pushed a commit
that referenced
this pull request
Aug 20, 2021
meringu
pushed a commit
to meringu/atlantis
that referenced
this pull request
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a config file so we can set ngrok's API port (web_addr). We use
the API to get the public URL and if there's already ngrok running, it
will just choose a random API port and we won't be able to get the right
url.
Fixes #92