Skip to content

Commit

Permalink
Merge pull request #1107 from grimm26/hide-comments
Browse files Browse the repository at this point in the history
Bring back clobbered hide-prev-commentds fix
  • Loading branch information
lkysow authored Jul 9, 2020
2 parents 0e7beab + caf3319 commit 1944657
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion server/events/vcs/github_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func NewGithubClient(hostname string, credentials GithubCredentials, logger *log
if err != nil {
return nil, err
}
graphqlURL = fmt.Sprintf("https://%s/graphql", apiURL.Host)
graphqlURL = fmt.Sprintf("https://%s/api/graphql", apiURL.Host)
}

// shurcooL's githubv4 library has a client ctor, but it doesn't support schema
Expand Down
4 changes: 2 additions & 2 deletions server/events/vcs/github_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func TestGithubClient_PaginatesComments(t *testing.T) {
testServer := httptest.NewTLSServer(
http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch r.Method + " " + r.RequestURI {
case "POST /graphql":
case "POST /api/graphql":
defer r.Body.Close() // nolint: errcheck
body, err := ioutil.ReadAll(r.Body)
if err != nil {
Expand Down Expand Up @@ -262,7 +262,7 @@ func TestGithubClient_HideOldComments(t *testing.T) {
case "GET /api/v3/repos/owner/repo/issues/123/comments?direction=asc&sort=created":
w.Write([]byte(issueResp)) // nolint: errcheck
return
case "POST /graphql":
case "POST /api/graphql":
if accept, has := r.Header["Accept"]; !has || accept[0] != "application/vnd.github.queen-beryl-preview+json" {
t.Error("missing preview header")
http.Error(w, "bad request", http.StatusBadRequest)
Expand Down

0 comments on commit 1944657

Please sign in to comment.