Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update perplexity models, add unit tests and minor fixes #17045

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

ivankqw
Copy link
Contributor

@ivankqw ivankqw commented Nov 23, 2024

Description

Fix: Update supported models in Perplexity and added integration tests

Fixes #17044

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 23, 2024
@ivankqw ivankqw changed the title Fix perplexity Fix: update perplexity models, add unit tests and minor fixes Nov 23, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 25, 2024
@ivankqw
Copy link
Contributor Author

ivankqw commented Nov 25, 2024

@logan-markewich added more tests (hopefully to increase test coverage) and linted

@logan-markewich logan-markewich enabled auto-merge (squash) November 25, 2024 20:07
@logan-markewich
Copy link
Collaborator

I think most of the tests are marked as skip without having an API key, But thats alright, better than nothing

@logan-markewich logan-markewich merged commit cac3256 into run-llama:main Nov 25, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Perplexity 400 Client Error: Bad Request for url
2 participants