Merge pull request #41 from run-as-root/develop

Adds patch data script to handle table data migration

Author: cristiano-pacheco

Diff for: src/Setup/Patch/Data/CopyDataFromOldMessageTable.php

@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RunAsRoot\MessageQueueRetry\Setup\Patch\Data;
+
+use Magento\Framework\Setup\ModuleDataSetupInterface;
+use Magento\Framework\Setup\Patch\DataPatchInterface;
+
+/**
+ * The reason for this class is to handle the migration from the old message table to the new one.
+ * This is necessary because errors are being generated during integration testes while using
+ * the onCreate="migrateDataFromAnotherTable('run_as_root_message')" in the db_schema.xml
+ */
+class CopyDataFromOldMessageTable implements DataPatchInterface
+{
+    public function __construct(
+        private readonly ModuleDataSetupInterface $moduleDataSetup,
+    ) {
+    }
+
+    public function getAliases(): array
+    {
+        return [];
+    }
+
+    public function apply(): self
+    {
+        $this->moduleDataSetup->startSetup();
+
+        $connection = $this->moduleDataSetup->getConnection();
+        $oldMessageTable = $this->moduleDataSetup->getTable('run_as_root_message');
+        $newMessageTable = $this->moduleDataSetup->getTable('run_as_root_queue_error_message');
+
+        if (!$connection->isTableExists($oldMessageTable) || !$connection->isTableExists($newMessageTable)) {
+            $this->moduleDataSetup->endSetup();
+            return $this;
+        }
+
+        $select = $connection->select()->from($oldMessageTable);
+        $connection->query($connection->insertFromSelect($select, $newMessageTable));
+
+        $this->moduleDataSetup->endSetup();
+
+        return $this;
+    }
+
+    public static function getDependencies(): array
+    {
+        return [];
+    }
+}

Diff for: src/Setup/Patch/Data/DeleteOldMessageTable.php

@@ -0,0 +1,50 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RunAsRoot\MessageQueueRetry\Setup\Patch\Data;
+
+use Magento\Framework\Setup\ModuleDataSetupInterface;
+use Magento\Framework\Setup\Patch\DataPatchInterface;
+
+/**
+ * The reason for this class is to handle the migration from the old message table to the new one.
+ * This is necessary because errors are being generated during integration testes while using
+ * the onCreate="migrateDataFromAnotherTable('run_as_root_message')" in the db_schema.xml
+ */
+class DeleteOldMessageTable implements DataPatchInterface
+{
+    public function __construct(
+        private readonly ModuleDataSetupInterface $moduleDataSetup,
+    ) {
+    }
+
+    public function getAliases(): array
+    {
+        return [];
+    }
+
+    public function apply(): self
+    {
+        $this->moduleDataSetup->startSetup();
+
+        $connection = $this->moduleDataSetup->getConnection();
+        $oldMessageTable = $this->moduleDataSetup->getTable('run_as_root_message');
+
+        if (!$connection->isTableExists($oldMessageTable)) {
+            $this->moduleDataSetup->endSetup();
+            return $this;
+        }
+
+        $connection->dropTable($oldMessageTable);
+
+        $this->moduleDataSetup->endSetup();
+
+        return $this;
+    }
+
+    public static function getDependencies(): array
+    {
+        return [ CopyDataFromOldMessageTable::class ];
+    }
+}

Diff for: src/etc/db_schema.xml

@@ -1,8 +1,7 @@
 <?xml version="1.0"?>
 <schema xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:framework:Setup/Declaration/Schema/etc/schema.xsd">
-    <table name="run_as_root_queue_error_message" onCreate="migrateDataFromAnotherTable(run_as_root_message)"
-           resource="default" engine="innodb">
+    <table name="run_as_root_queue_error_message" resource="default" engine="innodb">
         <column xsi:type="bigint" name="entity_id" unsigned="false" nullable="false" identity="true"/>
         <column xsi:type="varchar" name="topic_name" length="255" nullable="false"/>
         <column xsi:type="mediumtext" name="message_body" nullable="true"/>

Diff for: src/etc/db_schema_whitelist.json

@@ -1,23 +1,4 @@
 {
-    "run_as_root_message": {
-        "column": {
-            "entity_id": true,
-            "topic_name": true,
-            "message_body": true,
-            "failure_description": true,
-            "creation_time": true,
-            "update_time": true,
-            "resource_id": true,
-            "created_at": true,
-            "updated_at": true
-        },
-        "index": {
-            "RUN_AS_ROOT_MESSAGE_TOPIC_NAME": true
-        },
-        "constraint": {
-            "PRIMARY": true
-        }
-    },
     "run_as_root_queue_error_message": {
         "column": {
             "entity_id": true,
@@ -34,4 +15,4 @@
             "PRIMARY": true
         }
     }
-}
+}