Add support for JSON RPC named parameters

Author: Pedro Branco

docker-compose.yml

@@ -10,7 +10,7 @@ sut:
     - bitcoind-username-only
 
 bitcoind:
-  image: seegno/bitcoind:0.13.2-alpine
+  image: seegno/bitcoind:0.14.2-alpine
   command:
     -printtoconsole
     -regtest=1
@@ -26,7 +26,7 @@ bitcoind:
     - 18333:18333
 
 bitcoind-ssl:
-  image: seegno/bitcoind:0.11-alpine
+  image: seegno/bitcoind:0.14.2-alpine
   command:
     -printtoconsole
     -regtest=1
@@ -47,7 +47,7 @@ bitcoind-ssl:
     - 18334:18334
 
 bitcoind-username-only:
-  image: seegno/bitcoind:0.11-alpine
+  image: seegno/bitcoind:0.14.2-alpine
   command:
     -printtoconsole
     -regtest=1

src/index.js

@@ -113,6 +113,11 @@ class Client {
       parameters = _.dropRight(parameters);
     }
 
+    // Support named parameters.
+    if (parameters.length === 1 && _.isPlainObject(parameters[0])) {
+      parameters = parameters[0];
+    }
+
     return Promise.try(() => {
       if (Array.isArray(input)) {
         body = input.map((method, index) => this.requester.prepare({ method: method.method, parameters: method.parameters, suffix: index }));

test/index_test.js

@@ -193,6 +193,15 @@ describe('Client', () => {
 
         balance.should.be.a.Number();
       });
+
+      it('should support named parameters', async () => {
+        const balance = await new Client(config.bitcoind).getBalance({
+          account: '*',
+          minconf: 0
+        });
+
+        balance.should.be.a.Number();
+      });
     });
 
     describe('getDifficulty()', () => {
@@ -242,6 +251,16 @@ describe('Client', () => {
 
         transactions.should.be.an.Array().and.empty();
       });
+
+      it('should support named parameters', async () => {
+        let transactions = await new Client(config.bitcoind).listTransactions({ account: 'test' });
+
+        transactions.should.be.an.Array().and.empty();
+
+        transactions = await new Client(config.bitcoind).listTransactions({ account: 'test', count: 15 });
+
+        transactions.should.be.an.Array().and.empty();
+      });
     });
   });