Update to v1.1.3

downloaded: 2015-11-09

Author: rugk

README.md

@@ -1,6 +1,6 @@
 # [Threema Gateway](http://gateway.threema.ch/) PHP SDK
 
-Version: 1.1.2
+Version: 1.1.3
 
 Code analysers: [![Code Climate](https://codeclimate.com/github/rugk/threema-msgapi-sdk-php/badges/gpa.svg)](https://codeclimate.com/github/rugk/threema-msgapi-sdk-php) [![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/rugk/threema-msgapi-sdk-php/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/rugk/threema-msgapi-sdk-php/?branch=master) [![SensioLabsInsight](https://insight.sensiolabs.com/projects/b2d332ae-4100-42e0-abda-9cc96a79b18a/mini.png)](https://insight.sensiolabs.com/projects/b2d332ae-4100-42e0-abda-9cc96a79b18a) [![Codacy Badge](https://api.codacy.com/project/badge/grade/b90e43398be24c7fa417a43f02fbd31a)](https://www.codacy.com/app/c917250b/threema-msgapi-sdk-php)  
 All code analysers are configured to ignore `source/Salt/*` as this should not be part of the analyses.

source/Threema/MsgApi/Helpers/E2EHelper.php

@@ -11,6 +11,7 @@
 use Threema\MsgApi\Connection;
 use Threema\MsgApi\Messages\FileMessage;
 use Threema\MsgApi\Messages\ImageMessage;
+use Threema\MsgApi\Messages\ThreemaMessage;
 use Threema\MsgApi\Tools\CryptTool;
 use Threema\Core\Exception;
 use Threema\MsgApi\Tools\FileAnalysisTool;
@@ -178,6 +179,7 @@ public final function sendFileMessage($threemaId, $filePath, $thumbnailPath = nu
 		return $this->connection->sendE2E($threemaId, $nonce, $fileMessage);
 	}
 
+
 	/**
 	 * Encrypt a message and download the files of the message to the $outputFolder
 	 *
@@ -186,10 +188,19 @@ public final function sendFileMessage($threemaId, $filePath, $thumbnailPath = nu
 	 * @param string $box box as binary string
 	 * @param string $nonce nonce as binary string
 	 * @param string|null $outputFolder folder for storing the files
-	 * @throws \Threema\Core\Exception
+	 * @param \Closure $downloadMessage
 	 * @return ReceiveMessageResult
+	 * @throws Exception
+	 * @throws \Threema\MsgApi\Exceptions\BadMessageException
+	 * @throws \Threema\MsgApi\Exceptions\DecryptionFailedException
+	 * @throws \Threema\MsgApi\Exceptions\UnsupportedMessageTypeException
 	 */
-	public final function receiveMessage($threemaId, $messageId, $box, $nonce, $outputFolder = null) {
+	public final function receiveMessage($threemaId,
+										 $messageId,
+										 $box,
+										 $nonce,
+										 $outputFolder = null,
+										 \Closure $downloadMessage = null) {
 
 		if($outputFolder == null || strlen($outputFolder) == 0) {
 			$outputFolder = '.';
@@ -216,51 +227,48 @@ public final function receiveMessage($threemaId, $messageId, $box, $nonce, $outp
 		$receiveResult = new ReceiveMessageResult($messageId, $message);
 
 		if($message instanceof ImageMessage) {
-			$result = $this->connection->downloadFile($message->getBlobId());
-			if(null === $result || false === $result->isSuccess()) {
-				throw new Exception('could not download the image with blob id '.$message->getBlobId());
-			}
-
-			$image = $this->cryptTool->decryptImage(
-				$result->getData(),
-				hex2bin($receiverPublicKey->getPublicKey()),
-				$this->privateKey,
-				$message->getNonce()
-			);
+			$result = $this->downloadFile($message, $message->getBlobId(), $downloadMessage);
+			if(null !== $result && true === $result->isSuccess()) {
+				$image = $this->cryptTool->decryptImage(
+					$result->getData(),
+					hex2bin($receiverPublicKey->getPublicKey()),
+					$this->privateKey,
+					$message->getNonce()
+				);
+
+				if (null === $image) {
+					throw new Exception('decryption of image failed');
+				}
+				//save file
+				$filePath = $outputFolder . '/' . $messageId . '.jpg';
+				$f = fopen($filePath, 'w+');
+				fwrite($f, $image);
+				fclose($f);
 
-			if(null === $image) {
-				throw new Exception('decryption of image failed');
+				$receiveResult->addFile('image', $filePath);
 			}
-			//save file
-			$filePath = $outputFolder.'/'.$messageId.'.jpg';
-			$f = fopen($filePath, 'w+');
-			fwrite($f, $image);
-			fclose($f);
-
-			$receiveResult->addFile('image', $filePath);
 		}
 		else if($message instanceof FileMessage) {
-			$result = $this->connection->downloadFile($message->getBlobId());
-			if(null === $result || false === $result->isSuccess()) {
-				throw new Exception('could not download the file with blob id '.$message->getBlobId());
-			}
+			$result = $this->downloadFile($message, $message->getBlobId(), $downloadMessage);
 
-			$file = $this->cryptTool->decryptFile(
-				$result->getData(),
-				hex2bin($message->getEncryptionKey()));
+			if(null !== $result && true === $result->isSuccess()) {
+				$file = $this->cryptTool->decryptFile(
+					$result->getData(),
+					hex2bin($message->getEncryptionKey()));
 
-			if(null === $file) {
-				throw new Exception('file decryption failed');
-			}
+				if (null === $file) {
+					throw new Exception('file decryption failed');
+				}
 
-			//save file
-			$filePath =  $outputFolder.'/'.$messageId.'-'.$message->getFilename();
-			file_put_contents($filePath, $file);
+				//save file
+				$filePath = $outputFolder . '/' . $messageId . '-' . $message->getFilename();
+				file_put_contents($filePath, $file);
 
-			$receiveResult->addFile('file', $filePath);
+				$receiveResult->addFile('file', $filePath);
+			}
 
 			if(null !== $message->getThumbnailBlobId() && strlen($message->getThumbnailBlobId()) > 0) {
-				$result = $this->connection->downloadFile($message->getThumbnailBlobId());
+				$result = $this->downloadFile($message, $message->getThumbnailBlobId(), $downloadMessage);
 				if(null !== $result && true === $result->isSuccess()) {
 					$file = $this->cryptTool->decryptFileThumbnail(
 						$result->getData(),
@@ -285,9 +293,9 @@ public final function receiveMessage($threemaId, $messageId, $box, $nonce, $outp
 	 * Fetch a public key and check the capability of the threemaId
 	 *
 	 * @param string $threemaId
-	 * @param callable $capabilityCheck
+	 * @param \Closure $capabilityCheck
 	 * @return string Public key as binary
-	 * @throws \Threema\Core\Exception
+	 * @throws Exception
 	 */
 	private final function fetchPublicKeyAndCheckCapability($threemaId, \Closure $capabilityCheck = null) {
 		//fetch the public key
@@ -307,4 +315,25 @@ private final function fetchPublicKeyAndCheckCapability($threemaId, \Closure $ca
 
 		return hex2bin($receiverPublicKey->getPublicKey());
 	}
+
+	/**
+	 * @param ThreemaMessage $message
+	 * @param string $blobId blob id as hex
+	 * @param \Closure|null $downloadMessage
+	 * @return null|\Threema\MsgApi\Commands\Results\DownloadFileResult
+	 * @throws Exception
+	 */
+	private final function downloadFile(ThreemaMessage $message, $blobId, \Closure $downloadMessage = null) {
+		if(null === $downloadMessage
+			|| true === $downloadMessage->__invoke($message, $blobId)) {
+			//make a download
+			$result = $this->connection->downloadFile($blobId);
+			if(null === $result || false === $result->isSuccess()) {
+				throw new Exception('could not download the file with blob id '.$blobId);
+			}
+
+			return $result;
+		}
+		return null;
+	}
 }

source/bootstrap.php

@@ -19,7 +19,7 @@
 	}
 });
 
-$sdkVersion = '1.1.2';
+$sdkVersion = '1.1.3';
 define('MSGAPI_SDK_VERSION', $sdkVersion);
 $cryptTool = Threema\MsgApi\Tools\CryptTool::getInstance();