-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect display of messages on multiple lines #12
Comments
Also the action button must be wrapped… |
I can help with this but would need more context. |
Okay, thanks. You're right this needs a little more information. STRTrigger a long message, e.g. like this:
What happensWhat should happenAs per the linked doc in such a case the icon should be aligned at the top and not centered. Proposed solutionThis mostly needs some CSS quirks. |
@rugk Is this issue open for me to work on ? Thanks |
Of course, feel free to take it on. Thanks. 😃 |
I decided to do my own take on this and noticed too late that someone had already attempted it before (I'm new to contributing to open source projects) I've submitted my own PR on this issue nonetheless for your consideration. |
@Fanksies Sorry for the late reply, as far as I see in #226 I was not really satisfied with the solution to merge it yet. However, if you want, feel free to also look at the other PR. IÄm still seeking a "proper" solution for this issue. |
If this is still open to work on, I would like to give this a shot please. |
Sure, feel free to give it a try, @no1atall, I'll assign you. Please have a look at the previous (unsuccessful) tries, as you can see this is likely a tricky CSS task here… |
Is this issue still open, I'd fix it, but want a bit explanation how when the error message is displayed :) |
@Hamjaster Yeah, sure, you can take it. And thanks a lot in advance. If you have any issues or questions, e.g. how to implement a certain thing or how a thing works, feel free to ask. Also note GitHub's help can help on topics on how to use GitHub and e.g. how to create and update pull requests. As for how it should look, the initial link redirects now, but you can find it in the archive: https://web.archive.org/web/20220519062052/https://design.firefox.com/photon/components/message-bars.html#message-on-multiple-lines
BTW a JSFiddle or similar using the same CSS as we use, would also be very helpful for a start, as you can see there were many attempts at this one, but the CSS is not actually simple. Maybe one would need to switch to CSS grid? That could be a solution. |
https://design.firefox.com/photon/components/message-bars.html#message-on-multiple-lines
Currently the icon is e.g. shown in the middle anyway.
The text was updated successfully, but these errors were encountered: