Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump required ES version #813

Merged
merged 12 commits into from
Apr 17, 2015
Merged

Bump required ES version #813

merged 12 commits into from
Apr 17, 2015

Conversation

im-denisenko
Copy link
Contributor

Also added some of @deprecated docblocks

@ruflin
Copy link
Owner

ruflin commented Apr 6, 2015

@im-denisenko Let me know when this is ready to be merged, not that I merge it too early.

BTW: Nice list #812

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.68% when pulling cd54655 on im-denisenko:elasticsearch-1.5 into f2f75d4 on ruflin:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 84.7% when pulling 4c71c33 on im-denisenko:elasticsearch-1.5 into f2f75d4 on ruflin:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 84.7% when pulling 4c71c33 on im-denisenko:elasticsearch-1.5 into f2f75d4 on ruflin:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 84.71% when pulling c8ef848 on im-denisenko:elasticsearch-1.5 into f2f75d4 on ruflin:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 84.71% when pulling c8ef848 on im-denisenko:elasticsearch-1.5 into f2f75d4 on ruflin:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.13%) to 84.81% when pulling 165aacd on im-denisenko:elasticsearch-1.5 into f2f75d4 on ruflin:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.13%) to 84.81% when pulling 165aacd on im-denisenko:elasticsearch-1.5 into f2f75d4 on ruflin:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.13%) to 84.81% when pulling 165aacd on im-denisenko:elasticsearch-1.5 into f2f75d4 on ruflin:master.

ruflin
ruflin reviewed Apr 11, 2015
View reviewed changes
changes.txt
- Following methods in Elastica\Aggregation\DateHistogram marked as deprecated: setPreOffset, setPostOffset, setPreZone, setPostZone, setPreZoneAdjustLargeInterval

2015-04-07
- [BC break] Elastica\Query\QueryString::setLowercaseExpandedTerms removed
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know in which version of ES this was removed? I didn't check the changelog ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removed here and mentioned in changelog of 1.5.0.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@ruflin
Copy link
Owner

ruflin commented Apr 14, 2015

@im-denisenko I assume this pull request is ready to be merged?

@im-denisenko
Copy link
Contributor Author

@ruflin Sorry, I was quite busy recently. Yes, let's close it.

@ruflin ruflin merged commit 165aacd into ruflin:master Apr 17, 2015
@ruflin
Copy link
Owner

ruflin commented Apr 17, 2015

Merged. Thx.

@im-denisenko im-denisenko deleted the elasticsearch-1.5 branch April 21, 2015 00:03
@im-denisenko im-denisenko mentioned this pull request May 19, 2015
Closed
@im-denisenko im-denisenko mentioned this pull request May 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@im-denisenko @ruflin @coveralls