Add Elastica\Query\Image

[Jmoati]

Add support of https://github.com/kzwang/elasticsearch-image

[coveralls]

Coverage increased (+0.04%) to 84.44% when pulling 5f4d901 on Jmoati:master into 7f62b40 on ruflin:master.

[coveralls]

Coverage increased (+0.04%) to 84.44% when pulling 5f4d901 on Jmoati:master into 7f62b40 on ruflin:master.

[coveralls]

Coverage increased (+0.04%) to 84.44% when pulling 5f4d901 on Jmoati:master into 7f62b40 on ruflin:master.

[im-denisenko]

Is this plugin alive? I see they support ES 1.1.0, and last commit was half a year ago.
PR with support for 1.4.2 was opened month ago and still has no comments.
Elastica supports ES 1.4.3 right now, how would you use it with outdated plugin?

[Jmoati]

I use https://github.com/ifgh/elasticsearch-image which is a 1.4.2 fork.
I think that it will work with 1.4.3 too.

[ruflin]

To have a more readable path, check here: https://github.com/ruflin/Elastica/blob/master/test/lib/Elastica/Test/IndexTest.php#L124

[Jmoati]

Thx.

[ruflin]

To make sure it works with the current version, we should add an integration tests, which means we must add the plugin to our setup process. Like this we can also be sure it works with future versions.

Also we should add it then to the dependencies in the README file: https://github.com/ruflin/Elastica

@Jmoati If you need some help to get the setup done etc. we are here to help.

[im-denisenko]

More concrete steps how to add plugin to build:

• Add variable ES_IMAGE_PLUGIN_VER here
• Add plugin installation here
• Add plugin name here
• Add plugin to table of dependencies here
• Implement tests
• Add BIG BOLD docblock that this query is not standard functionality of ES. Like here

[Jmoati]

I will try this as soon as i can.

[coveralls]

Coverage increased (+0.33%) to 84.73% when pulling d7ed1ef on Jmoati:master into 7f62b40 on ruflin:master.

[coveralls]

Coverage increased (+0.06%) to 84.82% when pulling 56b5db7 on Jmoati:master into cc740b6 on ruflin:master.

[coveralls]

Coverage increased (+0.06%) to 84.82% when pulling 56b5db7 on Jmoati:master into cc740b6 on ruflin:master.

[Jmoati]

Can you please check.

[im-denisenko]

I guess "1.4.0" at the end of url also should use ES_IMAGE_PLUGIN_VER.

[Jmoati]

You are right.

[Jmoati]

It's fixed.

[im-denisenko]

All classes in Elastica\Query namespace can be instantiated by Elastica\QueryBuilder. You can add this query to querybuilder here (update every supported version) and here.

But this query isn't part of elasticsearch, so I'm not sure should it be added to querybuilder or not.
Guess @ruflin or @webdevsHub knows better.

[Jmoati]

Maybe, the PR can be accepted before I implement it in QueryBuilder if necessary?

[coveralls]

Coverage increased (+0.06%) to 84.82% when pulling 3c867e1 on Jmoati:master into cc740b6 on ruflin:master.

[coveralls]

Coverage increased (+0.06%) to 84.82% when pulling 3c867e1 on Jmoati:master into cc740b6 on ruflin:master.

[coveralls]

Coverage increased (+0.06%) to 84.82% when pulling 3c867e1 on Jmoati:master into cc740b6 on ruflin:master.

[ruflin]

Merged. Yes we can add it to the query builder in a second step.

[Jmoati]

Thx.

[webdevsHub]

I would prefer not to add it to Query DSL class because it is not an official elasticsearch query. Furthermore it will be difficult to update the Version classes with custom queries in the future.

However we could implement a new "plugin" DSL in QueryBuilder and put all the custom plugin stuff in there

$qb = new QueryBuilder();
$qb->plugin()->image(/*...*/);

// or
$qb->elastica()->image(/*...*/);

[ruflin]

@webdevsHub I like the "plugin DSL" idea.

[webdevsHub]

I will look into that during weekends. I want to add some comments to the QB unit tests anyway. Are there any other plugin related queries/aggs already implemented in Elastica that should be added to the new QB part?

[ruflin]

All the plugins are listed here in the README: https://github.com/ruflin/Elastica

Geocluster and attachment are the other two.