Add missing interface to ElasticsearchException #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each class in Elastica\Exception namespace: - Check if it implements ExceptionInterface - Check if it is inherited from \Exception
Guzzle/Thrift is optional packages, so: - munkie/elasticsearch-thrift-php must be installed for thrift test - guzzlehttp/guzzle must be installed for guzzle test
ruflin
added a commit
that referenced
this pull request
Jan 28, 2015
Add missing interface to ElasticsearchException
|
Merged. Of course some of the builds failed because of #759 (comment) ;-) |
|
BTW: With your recent pull requests you increased the coverage from 81% to at least 83% = Awesome |
|
yeah, awesome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition provides 100% assurance in behavior of code below (for example, used in Monolog):