#736: Additional Request Body Options for Percolator #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const EXTRA_AGGS = 'aggs'; | ||
| const EXTRA_HIGHLIGHT = 'highlight'; | ||
|
|
||
| private $extraRequestBodyOptions = array( |
There was a problem hiding this comment.
Can you use $_* for private and protected variables (naming convention).
|
Thank you for the addition. Can you adjust the naming of the function and variable? I assume with the next commit the tests should pass as I'm not sure why some failed before. |
| @@ -93,7 +115,26 @@ public function matchExistingDoc($id, $type, $query = null, $params = array()) | |||
| $id = urlencode($id); | |||
| $path = $this->_index->getName() . '/' . $type . '/'. $id . '/_percolate'; | |||
|
|
|||
| return $this->_percolate($path, $query, array(), $params); | |||
| $data = array(); | |||
| $this->applyAdditionalRequestBodyOptions($params, $data); | |||
There was a problem hiding this comment.
It should also be mentioned in the function params that these options can be set through param (line 110)
|
@ck99 Sorry for the delay. Now it is finally merged. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #736